Date: Wed, 6 Dec 2017 17:57:39 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
        linux-usb@vger.kernel.org, Daniel Drake <drake@endlessm.com>,
        Dmitry Fleytman <dmitry@daynix.com>,
        Eugene Korenevsky <ekorenevsky@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        =?iso-8859-1?Q?G=FCnter_R=F6ck?= <linux@roeck-us.net>,
        Johan Hovold <johan@kernel.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Peter Chen <peter.chen@nxp.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB: hub: Delete an error message for a failed memory
 allocation in usb_hub_clear_tt_buffer()
Message-ID: <20171206165739.GB23695@kroah.com>
References: <659939f3-da51-0cfd-2eb2-8a726cb1a42f@users.sourceforge.net>
 <Pine.LNX.4.44L0.1712061144310.1507-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44L0.1712061144310.1507-100000@iolanthe.rowland.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1350
Lines: 39

On Wed, Dec 06, 2017 at 11:45:31AM -0500, Alan Stern wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> 
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Wed, 6 Dec 2017 17:00:18 +0100
> > 
> > Omit an extra message for a memory allocation failure in this function.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  drivers/usb/core/hub.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> > index 7ccdd3d4db84..9fbb908e9552 100644
> > --- a/drivers/usb/core/hub.c
> > +++ b/drivers/usb/core/hub.c
> > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
> >  	 */
> >  	clear = kmalloc(sizeof *clear, GFP_ATOMIC);
> >  	if (clear == NULL) {
> > -		dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
> >  		/* FIXME recover somehow ... RESET_TT? */
> >  		return -ENOMEM;
> >  	}
> 
> Does the existing memory allocation error message include the 
> &udev->dev device name and driver name?  If it doesn't, there will be 
> no way for the user to tell that the error message is related to the 
> device failure.

Don't worry, I have a filter for this person's emails and do not see
their patches so they will not get applied.

thanks,

greg k-h