Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbdLFQ7A (ORCPT ); Wed, 6 Dec 2017 11:59:00 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:40984 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbdLFQ6z (ORCPT ); Wed, 6 Dec 2017 11:58:55 -0500 X-Google-Smtp-Source: AGs4zMbWsdIP58mbWUFxeSx/r50w08c0NqV5xGlJnTKO+kQWMsJhRX6G5/NT1miWELGUqgNspKFDCe0BLzCBFRZhayw= MIME-Version: 1.0 In-Reply-To: <5212497.opIP8sI45N@bentobox> References: <20171205143514.4441-1-sven.eckelmann@openmesh.com> <20171205143514.4441-3-sven.eckelmann@openmesh.com> <5212497.opIP8sI45N@bentobox> From: Willem de Bruijn Date: Wed, 6 Dec 2017 11:58:14 -0500 Message-ID: Subject: Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h To: Sven Eckelmann Cc: b.a.t.m.a.n@lists.open-mesh.org, Network Development , Eric Dumazet , LKML , Jiri Pirko , "David S . Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 27 On Wed, Dec 6, 2017 at 11:55 AM, Sven Eckelmann wrote: > On Mittwoch, 6. Dezember 2017 11:42:33 CET Willem de Bruijn wrote: >> On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann >> wrote: >> > This file contains the relevant information to let userspace communicate >> > with batman-adv over generic netlink. The relevant genl enums for the >> > attributes and commands have the prefix batadv_genl. Renaming this file to >> > this name therefore represents the content better and avoids confusion > with >> > the file which will contain the packet format definitions. >> > >> > Signed-off-by: Sven Eckelmann >> > --- >> > MAINTAINERS | 2 +- >> > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- >> >> This and the previous patch changes uapi. That might break userspace >> applications that rely on it. > > I am not aware of any application because all (alfred, batctl and some gluon > integration) of them currently ship their own copy because distribution didn't > catch up. And this is also the reason why I want to do it now - not later. That assumes that you know all applications, including those not publicly available. It may be true in this instance, but it is not possible to be certain.