Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752639AbdLFR2G (ORCPT ); Wed, 6 Dec 2017 12:28:06 -0500 Received: from mail-qt0-f172.google.com ([209.85.216.172]:46924 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325AbdLFR1k (ORCPT ); Wed, 6 Dec 2017 12:27:40 -0500 X-Google-Smtp-Source: AGs4zMaibNtbMflu5a9pNdNBlm6LlyWtNBhbF7x8TWVN1hiF+1treYQt31DNj/IZpS7YRipkYdMYCQ== From: Sven Eckelmann To: Willem de Bruijn Cc: Tom Herbert , Linux Kernel Network Developers , "David S . Miller" , Jiri Pirko , Eric Dumazet , LKML , b.a.t.m.a.n@lists.open-mesh.org Subject: Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers Date: Wed, 06 Dec 2017 18:27:37 +0100 Message-ID: <7082766.sOGqpe4oL6@bentobox> User-Agent: KMail/5.2.3 (Linux/4.13.0-0.bpo.1-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <20171205143514.4441-1-sven.eckelmann@openmesh.com> <1932095.qaFFlVjcYD@bentobox> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6239244.6zTq965KLP"; micalg="pgp-sha512"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2066 Lines: 50 --nextPart6239244.6zTq965KLP Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote: > Perhaps it can even be behind a static key depending on whether any > devices are active, adjusted in batadv_hardif_(en|dis)able_interface. I don't like that because we don't need batman-adv loaded to simply forward (bridge) traffic between interfaces. And not being able to use RPS with multiple cores just because the batman-adv module (and interfaces) is not enabled seems to be counter-intuitive. > Please implement FLOW_DISSECTOR_F_STOP_AT_ENCAP. It may > be used in more flow dissector paths in the future. > > The features are also used by GRE, which can encap Ethernet, for an example > that is closer to this protocol. Thanks for the feedback. I have it now implemented like in GRE. The change can already be found in https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/ecsv/flowdissector Kind regards, Sven --nextPart6239244.6zTq965KLP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlooKIkACgkQXYcKB8Em e0YOIw/+I6paHdeyQdB7Ip6fZoBJNM1UMjoOsNUUak9n2A+id4osWy/BODpWCkHd fpZs3LUVliZUUhMHGvEvfSyBTbtlRAh6TLWq0KjOyqc9nQoMTFNVmbl3R473ttdT 0ePN2aS8u2kJIjGn2Ja4tn75wUImS09WJKgNdaUL97oXxdvmEM48N7+HfLfO7Dg/ LVbt5fULRdWIV4DCypEnEHvpUoVcTzu2seNvQch1wGxmG2zSGlUhVPLT9bWqMgcC FcRbMXbYdGExJqjTtEXY6b7yQvfZi4xxFOghxHi8KhCtquMl1Vr7+89vxU4FArs5 vnhnsRSs3SwydA4qjpx7tTm9R8YuvyfMmebWZHPe4+8JbBE+7jV1Ek/hSnkl52ge mrTvsYwZzf9MShY1JjVdPPc63wXpeMk81UeaUu+++TJSrb8EPrsSMo/fFbL43S/Y igpO2tuSfTK5tZJdCLbKVPO/YHGAWjKGevc8HR+Lpwek6dm9D4v2J4vg0DgIAETT wpLh/tjZZD9dVNnzaDUByQuulDm7VW37PwbxWiiGtGMzZEHla8JzNoCtAO5B5agh AlcYtFK4KEillrfvvCy+l7vFautnTuOcudr0UT3o1ryHqGzVYiNKRbhoKbMi7WHj xz3kQAzYpJlIEJ+6DI/h6FS68Eb/CdZzc1qi34iIt9DuXn7O978= =xZBF -----END PGP SIGNATURE----- --nextPart6239244.6zTq965KLP--