Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbdLFSOd (ORCPT ); Wed, 6 Dec 2017 13:14:33 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:37163 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752368AbdLFSO3 (ORCPT ); Wed, 6 Dec 2017 13:14:29 -0500 X-Google-Smtp-Source: AGs4zMaC7UhaBPiFk/cbC4PG/qUToucAIsetbJWArNwaMWbDego8Bx26AJ8fkZ70ZLbr1UoU+LEDAtbBxEW6Viywj+E= MIME-Version: 1.0 In-Reply-To: References: <20171114123834.xsjiy2ynvott4gae@brain> <1511780854-7213-1-git-send-email-paolo.pisati@canonical.com> From: Paolo Pisati Date: Wed, 6 Dec 2017 19:14:26 +0100 Message-ID: Subject: Re: [PATCH v3] scripts/package: snap-pkg target To: Masahiro Yamada Cc: Jim Davis , Michal Marek , Behan Webster , Matthias Kaehlcke , =?UTF-8?Q?Vin=C3=ADcius_Tinti?= , linux-kbuild , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 27 On Wed, Dec 6, 2017 at 11:36 AM, Masahiro Yamada wrote: > Just one question to Paolo: > > If some change like firmware removal happens in the future, > patching for snapcraft is necessary? > (i.e. users are required to upgrade snapcraft from --edge ?) > > I guess the answer is yes, because "plugin: kernel" needs to know > the kernel-build system internal. Well, in this case, i had to fix the 'kernel-with-firmware' option to skip the 'firmware_install' step since we took it by default - let's say that in the future the 'modules_install' target is removed or change name, then i'll have to patch snapcraft. Wrt updating from -edge, i told you to take it from there because snap packages land there more often and more quickly compared to the canonicaldeb archive, so from a developer perspective it's easier&quicker to iterate over it, but sooner or later (e.g. once snapcraft 2.36.1 reaches the snap -stable channel), it will be copied to the deb archive too - IOW, you would get using apt-get only too. -- bye, p.