Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573AbdLFTQD (ORCPT ); Wed, 6 Dec 2017 14:16:03 -0500 Received: from mail.sigma-star.at ([95.130.255.111]:45996 "EHLO mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbdLFTP7 (ORCPT ); Wed, 6 Dec 2017 14:15:59 -0500 From: Richard Weinberger To: "Liu, Changcheng" , linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, gregkh@linuxfoundation.org, pombredanne@nexb.com, neilb@suse.com, akpm@linux-foundation.org Subject: Re: [PATCH] scripts/faddr2line: fix CROSS_COMPILE unset error Date: Wed, 06 Dec 2017 20:16:26 +0100 Message-ID: <3875933.96IucGWEYa@blindfold> In-Reply-To: <20171206013022.GA83929@sofia> References: <20171206013022.GA83929@sofia> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 32 Am Mittwoch, 6. Dezember 2017, 02:30:22 CET schrieb Liu, Changcheng: > faddr2line hit var unbound error When CROSS_COMPILE > isn't set since nounset option is set in bash script. > > Signed-off-by: Liu Changcheng > Reported-by: Richard Weinberger > > diff --git a/scripts/faddr2line b/scripts/faddr2line > index 39e07d8..7721d5b 100755 > --- a/scripts/faddr2line > +++ b/scripts/faddr2line > @@ -44,10 +44,10 @@ > set -o errexit > set -o nounset > > -READELF="${CROSS_COMPILE}readelf" > -ADDR2LINE="${CROSS_COMPILE}addr2line" > -SIZE="${CROSS_COMPILE}size" > -NM="${CROSS_COMPILE}nm" > +READELF="${CROSS_COMPILE:-}readelf" > +ADDR2LINE="${CROSS_COMPILE:-}addr2line" > +SIZE="${CROSS_COMPILE:-}size" > +NM="${CROSS_COMPILE:-}nm" > > command -v awk >/dev/null 2>&1 || die "awk isn't installed" > command -v ${READELF} >/dev/null 2>&1 || die "readelf isn't installed" Fixes: 95a879825419 ("scripts/faddr2line: extend usage on generic arch") Reviewed-by: Richard Weinberger Thanks, //richard