Date: Wed, 06 Dec 2017 14:40:03 -0500 (EST)
Message-Id: <20171206.144003.2119311447846512879.davem@davemloft.net>
To: cernekee@chromium.org
Cc: johannes.berg@intel.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH] netlink: Add netns check on taps
From: David Miller <davem@davemloft.net>
In-Reply-To: <1512513982-20407-1-git-send-email-cernekee@chromium.org>
References: <1512513982-20407-1-git-send-email-cernekee@chromium.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1190
Lines: 33

From: Kevin Cernekee <cernekee@chromium.org>
Date: Tue,  5 Dec 2017 14:46:22 -0800

> Currently, a nlmon link inside a child namespace can observe systemwide
> netlink activity.  Filter the traffic so that in a non-init netns,
> nlmon can only sniff netlink messages from its own netns.
> 
> Test case:
> 
>     vpnns -- bash -c "ip link add nlmon0 type nlmon; \
>                       ip link set nlmon0 up; \
>                       tcpdump -i nlmon0 -q -w /tmp/nlmon.pcap -U" &
>     sudo ip xfrm state add src 10.1.1.1 dst 10.1.1.2 proto esp \
>         spi 0x1 mode transport \
>         auth sha1 0x6162633132330000000000000000000000000000 \
>         enc aes 0x00000000000000000000000000000000
>     grep abc123 /tmp/nlmon.pcap
> 
> Signed-off-by: Kevin Cernekee <cernekee@chromium.org>

Daniel, what behavior did you intend this to have?

Taps can see their own namespace only, or init_net is special
and can see all netlink activity.

I think letting init_net see everything could be confusing,
because there is no way to distinguish netlink events by
namespace just by looking at the messages that arrive at
the tap right?

So maybe own-namespace-only is the way to go.

Thanks.