Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbdLFVME (ORCPT ); Wed, 6 Dec 2017 16:12:04 -0500 Received: from mout.web.de ([212.227.15.14]:55054 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbdLFVMB (ORCPT ); Wed, 6 Dec 2017 16:12:01 -0500 Subject: [PATCH 1/3] tty/serial/ucc_uart: Delete an error message for a failed memory allocation in ucc_uart_probe() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Timur Tabi Cc: LKML , kernel-janitors@vger.kernel.org References: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Message-ID: Date: Wed, 6 Dec 2017 22:11:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:2RSq5Or7dlejv7tHyaxIPj5KZDmYjU71nahW2N9q/fPMEubu6yw f3p7RobvY76tgEgbkp9tRN+kSZQrFNWsObcSW+ABKk7urG48aXpk7/UME842ZfTWuzaWqrJ JY32dv6S66MfUry9fI8Kku7os0fQB6bYpS+fpxUdBe4eJuyjKayUChFs+JJ70zB8lVhKjBb /KaHErokrQdZyzZGls6Uw== X-UI-Out-Filterresults: notjunk:1;V01:K0:a5xmyu9v1TY=:AWtbUQYlenyyI3zDHWRCwa KwRyEZeKvE+T2ZdojqsS2w/kpNtPQG202ep7lU6HuKgP5bL7cKMGWfJfrNqApYzamfbPd2Cgm NZKJhQ3Pp5C1ei2cwwWeRgjDWpJcLxKFrBgmlpOiflpFStVl3CdG6O9DKrxjXAsqJWJ0x+cPr 5xaVZV/BQLdSva6Va5KvK0MJvD8UPwiSNoBDPq8iGtBgn9UiO1TVql0yR1hVLE0s3SyAF9K2T jvFMhPduXGeAf2lWus12gyme9uIqH3tRAjRtkNHc+iW0QBiGflJWhOsYj3zX0sEQCjbwfxvjt zUTaN+/+CIgDCc7R0UZQXruHMzI80IAgBF+8tYVpRLRchgyNNDI5GFYhv1Wk0t/d2aqicpY5T fj3niSELsy890GLD4C6gC2ujSN7/d8dFjN4NznZy52iSXCiNJJB9zxTTfqhpahwXW+dWzGnkp 4lsV5Tu1V4AdDJIYDOc45jPu7Y2qsqZe2rtHETa14XfFEGSrGTW9kaiQc2sXU9Ls94ihXZxGY 6q7pddtftc+LXBodfbJPNbzCbPUlSHWzqXOgJNa0FC7pFRywBOZeGj9DSjrS0IirV43nvYo1m eJ8vTFjvEQrXnh6eKTuISgCNbKzDHT7ODHIWFo+BzE+rVQ3X6FdAOi7owNc8HkwPwFPuo/uGI MvvDuMvthSCqr52OIWVBnWzVRsPRfciKiD6kemN+ik+dyRTTDkTYwgMDOvwygrhAyT/mvOwfw vrHu6qC9SiTUpZemoWEbXRA3bLWXVUqkHMIledhQFJNNIjQhmRBXS6P6mQsRvTEojLQdqNZBE A4HTwz0/7gUwxOjdgT8AfgnpgHIWTEHUo4fUm9XKBqavF52fiVn7WaIwKJPUXDQJ0A5h/aS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 30 From: Markus Elfring Date: Wed, 6 Dec 2017 21:41:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ucc_uart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 2b6376e6e5ad..48364f0eba72 100644 --- a/drivers/tty/serial/ucc_uart.c +++ b/drivers/tty/serial/ucc_uart.c @@ -1254,10 +1254,8 @@ static int ucc_uart_probe(struct platform_device *ofdev) } qe_port = kzalloc(sizeof(struct uart_qe_port), GFP_KERNEL); - if (!qe_port) { - dev_err(&ofdev->dev, "can't allocate QE port structure\n"); + if (!qe_port) return -ENOMEM; - } /* Search for IRQ and mapbase */ ret = of_address_to_resource(np, 0, &res); -- 2.15.1