Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591AbdLFVOC (ORCPT ); Wed, 6 Dec 2017 16:14:02 -0500 Received: from mout.web.de ([212.227.15.14]:53980 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbdLFVNa (ORCPT ); Wed, 6 Dec 2017 16:13:30 -0500 Subject: [PATCH 2/3] tty/serial/ucc_uart: Improve a size determination in ucc_uart_probe() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Timur Tabi Cc: LKML , kernel-janitors@vger.kernel.org References: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Message-ID: <38dd53cc-f7e8-57b9-bd0f-0946c787ac2e@users.sourceforge.net> Date: Wed, 6 Dec 2017 22:12:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:NCNzkvvHHx8nJskUWjGDBxV79mC1P1iIcKBRFlxye25z4GLQPMn cBsmCRKSIXvTRo7YT6KhzIcemL8j/x1uprkRuyaDPkxDOiReXJZtoW9F4xLd1/uXfnZ8uJ5 bknOF6rYEXlUpSM5aMkgOrncKg2coYdxY9ht+G+pMdQkDUr9JovmtqMQNRBl6p78ADWCuix 5979hBWfoF114Yd/mqB1g== X-UI-Out-Filterresults: notjunk:1;V01:K0:gtc0NEWulpI=:eyeTPjUSjHJ9ZHFlVm+Whv R+qlAPGiJchDIuFzZzG9qtPgPONhLe/ThYyg0XXX0rtrVo3RSrqJIxF9UNShw8yhNpLWYutSp u3+mdrXkPuHWszOIEu2eDr13pTn5nVTsg61lgoJD3gu7oUlBRtUgmpkKK1lzQOrnRr4mFoHZE 5I4pK04h/nsVT4YXAjYQnN7FCsZfnNipqGLdJ4pp5jvptDon8+NN8pqB1zEbSx5qFHPkaMEDE Kfj9gwOrucS5QCPjSpTg+BTd0UquDj1+2DAJYb9dV9SJMSPZtP7hqAQ32rh0FsIcuzcxIQMxC U7N7v4zzNKbSxEEq3FbzR+XemXOStDfd17CX+EvIEAWBxw35qZlyzn2E13qBz+AXEJ/8UmNgZ RmJ3J8B0T40IzpaV84qLl8OS6OpPnuiVsXxenzy9lCXfM4rE/B8i35qfmL+D3Lnnp95SQudMc fwDXu4IoVyygBENrpnYJ3JNlM2HI4i4syLRDjTCtnyy7RnREM/9KJ1WKwtR59siyjtSuwbYcE GrZWn3GLotUBwDcz5LmFPANnFhPmPhNH8UcjmzX/kQ0ikXqE8NGDNdEYhGYLp50ce40ev+TaO Qpj+iZrzKZ+D7hIS4l2l1O42JlXA/wDssA+iOaxgQWo5fZO6MAr+6jQFHQEXb0jRXbq8ptVjz 9DhMZ1/2rNbk1XfS8LOvCXkuk7F0UDmXoohfaWNiMJoLZZ/9koYigMuQc+HAP2jqkJsOoITBX bLCgnz1ofcYKxHQvoeJ8aXIk/RNwdIPR9AnN3YTHvZJtLDbahXhJjOpQ/ZlclTXhEol+J6XSb LVwM8IdRDjW+zNKgvUiWN0GQR1Ia+4mfFY/9wpsz3ZB5x8ZEQpXZOADBUc6UxTfXIQZRlXP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 29 From: Markus Elfring Date: Wed, 6 Dec 2017 21:45:32 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ucc_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 48364f0eba72..a9ce652899aa 100644 --- a/drivers/tty/serial/ucc_uart.c +++ b/drivers/tty/serial/ucc_uart.c @@ -1253,7 +1253,7 @@ static int ucc_uart_probe(struct platform_device *ofdev) } } - qe_port = kzalloc(sizeof(struct uart_qe_port), GFP_KERNEL); + qe_port = kzalloc(sizeof(*qe_port), GFP_KERNEL); if (!qe_port) return -ENOMEM; -- 2.15.1