Subject: Re: USB: hub: Delete an error message for a failed memory allocation
 in usb_hub_clear_tt_buffer()
To: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org
Cc: Joe Perches <joe@perches.com>, Daniel Drake <drake@endlessm.com>,
        Dmitry Fleytman <dmitry@daynix.com>,
        Eugene Korenevsky <ekorenevsky@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= <linux@roeck-us.net>,
        Johan Hovold <johan@kernel.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Peter Chen <peter.chen@nxp.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <Pine.LNX.4.44L0.1712061618140.1507-100000@iolanthe.rowland.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <a823c472-7826-3fbd-0197-5246a2cd5368@users.sourceforge.net>
Date: Wed, 6 Dec 2017 22:33:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <Pine.LNX.4.44L0.1712061618140.1507-100000@iolanthe.rowland.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 597
Lines: 18

>>> Does the existing memory allocation error message include the 
>>> &udev->dev device name and driver name?  If it doesn't, there will be 
>>> no way for the user to tell that the error message is related to the 
>>> device failure.
>>
>> No, but the effect is similar.
>>
>> OOM does a dump_stack() so this function's call tree is shown.
> 
> A call stack doesn't tell you which device was being handled.

Do you find a default Linux allocation failure report insufficient then?

Would you like to to achieve that the requested information can be determined
from a backtrace?

Regards,
Markus