Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbdLFWHi (ORCPT ); Wed, 6 Dec 2017 17:07:38 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:35164 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdLFWHh (ORCPT ); Wed, 6 Dec 2017 17:07:37 -0500 X-Google-Smtp-Source: AGs4zMaEUFi8O3C5eg+9FZcvgEE/51DHzCEPTTtQKuZYnIrBFWirZE4DGrFNeKVP7ZqQ9Kgf6z7d2g== Date: Wed, 6 Dec 2017 16:07:35 -0600 From: Rob Herring To: Frank Rowand Cc: Geert Uytterhoeven , Pantelis Antoniou , Colin King , Dan Carpenter , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] of: overlay: Fix of_overlay_apply() error path Message-ID: <20171206220735.ior2jbznzbeml5re@rob-hp-laptop> References: <1512487623-30450-1-git-send-email-geert+renesas@glider.be> <48dd6ac2-6481-4164-6051-ec9fd98490fb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48dd6ac2-6481-4164-6051-ec9fd98490fb@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 31 On Tue, Dec 05, 2017 at 09:40:33PM -0500, Frank Rowand wrote: > On 12/05/17 10:27, Geert Uytterhoeven wrote: > > Hi Pantelis, Rob, Frank, > > > > Here's a replacement for commit bd80e2555c5c9d45 ("of: overlay: Fix > > cleanup order in of_overlay_apply()"), which was applied by Rob, and > > dropped later. > > > > The first patch fixes the memory leak reported by Colin. > > The second patch is a replacement for the bad dropped commit, and > > depends on the first patch for proper cleanup. > > > > All OF unittests pass. > > > > Thanks! > > > > Geert Uytterhoeven (2): > > of: overlay: Fix memory leak in of_overlay_apply() error path > > of: overlay: Fix (un)locking in of_overlay_apply() > > > > drivers/of/overlay.c | 31 +++++++++++++------------------ > > 1 file changed, 13 insertions(+), 18 deletions(-) > > > > Thank you, the code is much improved by these patches. > > Reviewed-by: Frank Rowand Applied. Rob