Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071AbdLFWYn (ORCPT ); Wed, 6 Dec 2017 17:24:43 -0500 Received: from dd39320.kasserver.com ([85.13.155.146]:44078 "EHLO dd39320.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdLFWYm (ORCPT ); Wed, 6 Dec 2017 17:24:42 -0500 Subject: Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h To: =?UTF-8?Q?Simon_Sandstr=c3=b6m?= , gregkh@linuxfoundation.org Cc: linux@Wolf-Entwicklungen.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20171206204224.14714-1-simon@nikanor.nu> <20171206204224.14714-6-simon@nikanor.nu> From: Marcus Wolf Message-ID: <39be3007-a0a6-01ba-aca7-856c8e6f1ed0@smarthome-wolf.de> Date: Thu, 7 Dec 2017 00:24:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171206204224.14714-6-simon@nikanor.nu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 57 Am 06.12.2017 um 22:42 schrieb Simon Sandström: > The enum is now only used for ioctl, so move it pi433_if.h. > > Signed-off-by: Simon Sandström > --- > drivers/staging/pi433/pi433_if.h | 5 +++++ > drivers/staging/pi433/rf69_enum.h | 5 ----- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h > index bcfe29840889..c8697d144e2b 100644 > --- a/drivers/staging/pi433/pi433_if.h > +++ b/drivers/staging/pi433/pi433_if.h > @@ -37,6 +37,11 @@ > > /*---------------------------------------------------------------------------*/ > > +enum option_on_off { > + OPTION_OFF, > + OPTION_ON > +}; > + > /* IOCTL structs and commands */ > > /** > diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h > index b0715b4eb6ac..4e64e38ae4ff 100644 > --- a/drivers/staging/pi433/rf69_enum.h > +++ b/drivers/staging/pi433/rf69_enum.h > @@ -18,11 +18,6 @@ > #ifndef RF69_ENUM_H > #define RF69_ENUM_H > > -enum option_on_off { > - OPTION_OFF, > - OPTION_ON > -}; > - > enum mode { > mode_sleep, > standby, > Hi Simon, sorry - I have one more question. Why do you want to get rid of the enum option_on_off in rf69_enum.h. I generated that file just to store the enums. Now we have one enum at an other place... Regards, Marcus