Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbdLFW1o (ORCPT ); Wed, 6 Dec 2017 17:27:44 -0500 Received: from mail.sigma-star.at ([95.130.255.111]:45996 "EHLO mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdLFW1n (ORCPT ); Wed, 6 Dec 2017 17:27:43 -0500 From: Richard Weinberger To: Christophe Leroy Cc: Boris Brezillon , linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: nand: gpio: Fix ALE gpio configuration Date: Wed, 06 Dec 2017 23:28:11 +0100 Message-ID: <18914914.8jQtQ4ab2h@blindfold> In-Reply-To: <20171206172714.ABE156C6B0@po15668-vm-win7.idsi0.si.c-s.fr> References: <20171206172714.ABE156C6B0@po15668-vm-win7.idsi0.si.c-s.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 32 Am Mittwoch, 6. Dezember 2017, 18:27:14 CET schrieb Christophe Leroy: > Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio: > Convert to use GPIO descriptors") which breaks gpio-nand driver > > Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors") > Cc: Linus Walleij > Signed-off-by: Christophe Leroy > --- > drivers/mtd/nand/gpio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c > index 484f7fbc3f7d..a8bde6665c24 100644 > --- a/drivers/mtd/nand/gpio.c > +++ b/drivers/mtd/nand/gpio.c > @@ -253,9 +253,9 @@ static int gpio_nand_probe(struct platform_device *pdev) > goto out_ce; > } > > - gpiomtd->nwp = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW); > - if (IS_ERR(gpiomtd->nwp)) { > - ret = PTR_ERR(gpiomtd->nwp); > + gpiomtd->ale = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW); > + if (IS_ERR(gpiomtd->ale)) { > + ret = PTR_ERR(gpiomtd->ale); > goto out_ce; > } Reviewed-by: Richard Weinberger Thanks, //richard