Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbdLFWeA (ORCPT ); Wed, 6 Dec 2017 17:34:00 -0500 Received: from mail1.windriver.com ([147.11.146.13]:39417 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdLFWd6 (ORCPT ); Wed, 6 Dec 2017 17:33:58 -0500 From: Jason Wessel To: CC: , Subject: [PATCH 1/2] kdb: Fix handling of kallsyms_symbol_next() return value Date: Wed, 6 Dec 2017 16:33:44 -0600 Message-ID: <1512599625-388-2-git-send-email-jason.wessel@windriver.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1512599625-388-1-git-send-email-jason.wessel@windriver.com> References: <1512599625-388-1-git-send-email-jason.wessel@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 32 From: Daniel Thompson kallsyms_symbol_next() returns a boolean (true on success). Currently kdb_read() tests the return value with an inequality that unconditionally evaluates to true. This is fixed in the obvious way and, since the conditional branch is supposed to be unreachable, we also add a WARN_ON(). Reported-by: Dan Carpenter Signed-off-by: Daniel Thompson Cc: linux-stable Signed-off-by: Jason Wessel --- kernel/debug/kdb/kdb_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index e74be38..ed5d349 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -350,7 +350,7 @@ static char *kdb_read(char *buffer, size_t bufsize) } kdb_printf("\n"); for (i = 0; i < count; i++) { - if (kallsyms_symbol_next(p_tmp, i) < 0) + if (WARN_ON(!kallsyms_symbol_next(p_tmp, i))) break; kdb_printf("%s ", p_tmp); *(p_tmp + len) = '\0'; -- 1.9.1