Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbdLFWpx (ORCPT ); Wed, 6 Dec 2017 17:45:53 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43047 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbdLFWpu (ORCPT ); Wed, 6 Dec 2017 17:45:50 -0500 Date: Wed, 6 Dec 2017 23:45:38 +0100 From: Boris Brezillon To: Richard Weinberger Cc: Christophe Leroy , linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: nand: gpio: Fix ALE gpio configuration Message-ID: <20171206234538.08a84f8a@bbrezillon> In-Reply-To: <20171206233927.3869372b@bbrezillon> References: <20171206172714.ABE156C6B0@po15668-vm-win7.idsi0.si.c-s.fr> <18914914.8jQtQ4ab2h@blindfold> <20171206233927.3869372b@bbrezillon> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 49 On Wed, 6 Dec 2017 23:39:27 +0100 Boris Brezillon wrote: > On Wed, 06 Dec 2017 23:28:11 +0100 > Richard Weinberger wrote: > > > Am Mittwoch, 6. Dezember 2017, 18:27:14 CET schrieb Christophe Leroy: > > > Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio: > > > Convert to use GPIO descriptors") which breaks gpio-nand driver > > > > > > Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors") > > > Cc: Linus Walleij > > Cc: Oops, forget the Cc-stable tag, f3d0d8d938b4d has been merged in 4.15-rc1. > Acked-by: Boris Brezillon > > Richard, can you queue that one to the fixes branch? > > > > Signed-off-by: Christophe Leroy > > > --- > > > drivers/mtd/nand/gpio.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c > > > index 484f7fbc3f7d..a8bde6665c24 100644 > > > --- a/drivers/mtd/nand/gpio.c > > > +++ b/drivers/mtd/nand/gpio.c > > > @@ -253,9 +253,9 @@ static int gpio_nand_probe(struct platform_device *pdev) > > > goto out_ce; > > > } > > > > > > - gpiomtd->nwp = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW); > > > - if (IS_ERR(gpiomtd->nwp)) { > > > - ret = PTR_ERR(gpiomtd->nwp); > > > + gpiomtd->ale = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW); > > > + if (IS_ERR(gpiomtd->ale)) { > > > + ret = PTR_ERR(gpiomtd->ale); > > > goto out_ce; > > > } > > > > Reviewed-by: Richard Weinberger > > > > Thanks, > > //richard >