Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbdLFXzh (ORCPT ); Wed, 6 Dec 2017 18:55:37 -0500 Received: from zimbra.linuxprofi.at ([93.83.54.199]:48716 "EHLO zimbra.linuxprofi.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbdLFXze (ORCPT ); Wed, 6 Dec 2017 18:55:34 -0500 Date: Thu, 7 Dec 2017 00:55:34 +0100 From: Christoph =?utf-8?Q?B=C3=B6hmwalder?= To: Ognjen Galic Cc: "Rafael J. Wysocki" , Len Brown , Robert Moore , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, Henrique de Moraes Holschuh , Darren Hart , Andy Shevchenko , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 2/3] battery: Add the ThinkPad "Not Charging" quirk Message-ID: <20171206235534.5d7vm24u3ofegfwn@localhost> Mail-Followup-To: Ognjen Galic , "Rafael J. Wysocki" , Len Brown , Robert Moore , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, Henrique de Moraes Holschuh , Darren Hart , Andy Shevchenko , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org References: <20171206225301.GA3837@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171206225301.GA3837@thinkpad> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 634 Lines: 18 On Wed, Dec 06, 2017 at 11:53:01PM +0100, Ognjen Galic wrote: > The EC/ACPI firmware on Lenovo ThinkPads used to report a status > of "Unknown" when the battery is between the charge start and > charge stop thresholds. On Windows, it reports "Not Charging" > so the quirk has been added to also report correctly. > > Now the "status" attribute returns "Not Charging" when the > battery on ThinkPads is not physicaly charging. Hi again, I just tried this patch(set) and it still seems to report "Unknown". We can also discuss this on the IRC you mentioned earlier if you want, as I said I'm open for testing. -- Regards, Christoph