Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbdLGAkB (ORCPT ); Wed, 6 Dec 2017 19:40:01 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:41447 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbdLGAkA (ORCPT ); Wed, 6 Dec 2017 19:40:00 -0500 Subject: Re: [PATCH] doc: convert printk-formats.txt to rst To: "Tobin C. Harding" Cc: Jonathan Corbet , Andrew Murray , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1512524729-16051-1-git-send-email-me@tobin.cc> <20171206211651.GD11835@eros> From: Randy Dunlap Message-ID: Date: Wed, 6 Dec 2017 16:39:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171206211651.GD11835@eros> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1992 Lines: 58 On 12/06/2017 01:16 PM, Tobin C. Harding wrote: > On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: > > Thanks for your comments Randy. > >>> Documentation/index.rst | 10 + >>> .../{printk-formats.txt => printk-formats.rst} | 295 ++++++++++++--------- >>> lib/vsprintf.c | 160 +++++------ >>> 3 files changed, 235 insertions(+), 230 deletions(-) >>> rename Documentation/{printk-formats.txt => printk-formats.rst} (61%) >> >>> diff --git a/Documentation/printk-formats.txt b/Documentation/printk-formats.rst >>> similarity index 61% >>> rename from Documentation/printk-formats.txt >>> rename to Documentation/printk-formats.rst >>> index aa0a776c817a..51449d213748 100644 >>> --- a/Documentation/printk-formats.txt >>> +++ b/Documentation/printk-formats.rst >>> @@ -194,8 +233,8 @@ printing SSIDs. >>> >>> If field width is omitted the 1 byte only will be escaped. >> >> then >> I think... > > Ha ha, I was borderline with this change when doing this patch. It may > not appear so but I did try to do the minimal amount of changes while > improving correctness. I appreciate your comments since hopefully I can > better make these judgment calls next time. I wasn't so sure about that attempt (at minimal changes). :) > Will change as suggested. >>> Where no additional specifiers are used the default big endian >>> -order with lower case hex characters will be printed. >>> +order with lower case hex digits will be printed. >> >> digits could imply base 10. but no big deal. > > Are you sure about this? I was under the impression that when > representing a number the character set used are refereed to as 'digits' > irrespective of base. > > hexadecimal digit > octal digit > digit (assumed base 10) > > Open to correction though. Like I said, I don't care strongly about this. (I'm easy.) but hex notation (like you said later) sounds good. -- ~Randy