Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbdLGDY6 (ORCPT ); Wed, 6 Dec 2017 22:24:58 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:50948 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990AbdLGDY5 (ORCPT ); Wed, 6 Dec 2017 22:24:57 -0500 X-Google-Smtp-Source: AGs4zMYawYQRcI3U/j1B25QieS2aSMLrdlSQ+DIVOxx7tWpGI1WX48mVu2Fsb8A2q4tUqJN3+to39KL3OzlUQUxZ6Gk= MIME-Version: 1.0 In-Reply-To: <1512582664-24936-1-git-send-email-jagan@amarulasolutions.com> References: <1512582664-24936-1-git-send-email-jagan@amarulasolutions.com> From: Chen-Yu Tsai Date: Thu, 7 Dec 2017 11:24:31 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] arm64: allwinner: a64: bananapi-m64: add usb otg To: Jagan Teki Cc: Maxime Ripard , Chen-Yu Tsai , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi , Jagan Teki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 16 On Thu, Dec 7, 2017 at 1:51 AM, Jagan Teki wrote: > usb otg on bananapi-m64 has configured with USB-ID with PH9 > and USB-DRVVBUS attached with dcdc1 regulatort. That is not how you read the schematic... Intersecting lines that are tied together will have a dot representing the connection. The DCDC1 line is a pull-up for the ID pin. This is very clear because it has a resistor connected in series. VBUS for OTG is controlled by the IC displayed to the right in the schematic, which is powered from 5V, and controlled by the DRVVBUS pin from the PMIC. Please take a look at how the A31/A33/A83T board dts files represent this. ChenYu