Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752342AbdLGEZZ (ORCPT ); Wed, 6 Dec 2017 23:25:25 -0500 Received: from ozlabs.org ([103.22.144.67]:42639 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbdLGEZX (ORCPT ); Wed, 6 Dec 2017 23:25:23 -0500 Date: Thu, 7 Dec 2017 15:25:21 +1100 From: Stephen Rothwell To: Bart Van Assche Cc: "Martin K. Petersen" , Linus Kernel Mailing List , Linux Next Mailing List , Pavel Tikhomirov , "Paul E. McKenney" , Josh Triplett Subject: Re: linux-next: build failure after merge of the scsi-mkp tree Message-ID: <20171207152521.0036b131@canb.auug.org.au> In-Reply-To: <1512619169.3298.3.camel@wdc.com> References: <20171207145728.57cd9ac4@canb.auug.org.au> <1512619169.3298.3.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 28 Hi Bart, [cc'ing some RCU people ...] On Thu, 7 Dec 2017 03:59:30 +0000 Bart Van Assche wrote: > > On Thu, 2017-12-07 at 14:57 +1100, Stephen Rothwell wrote: > > After merging the scsi-mkp tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined! > > ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined! > > > > Caused by commit > > > > ac90420f17c9 ("scsi: core: Ensure that the SCSI error handler gets woken up") > > > > I have used the scsi-mkp tree from next-20171206 for today. > > Does that mean I'm the first one who added RCU code to the SCSI core? The only other uses of init_rcu_head() are in drivers/iommu/intel-svm.c and kernel/irq/irqdesc.c. destroy_rcu_head() appears to not be used anywhere ... -- Cheers, Stephen Rothwell