Date: Thu, 7 Dec 2017 07:14:09 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Cc: Simon =?iso-8859-1?Q?Sandstr=F6m?= <simon@nikanor.nu>,
        devel@driverdev.osuosl.org, linux@Wolf-Entwicklungen.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h
Message-ID: <20171207061409.GA7545@kroah.com>
References: <20171206204224.14714-1-simon@nikanor.nu>
 <20171206204224.14714-6-simon@nikanor.nu>
 <39be3007-a0a6-01ba-aca7-856c8e6f1ed0@smarthome-wolf.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <39be3007-a0a6-01ba-aca7-856c8e6f1ed0@smarthome-wolf.de>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1709
Lines: 59

On Thu, Dec 07, 2017 at 12:24:34AM +0200, Marcus Wolf wrote:
> 
> 
> Am 06.12.2017 um 22:42 schrieb Simon Sandstr?m:
> > The enum is now only used for ioctl, so move it pi433_if.h.
> > 
> > Signed-off-by: Simon Sandstr?m <simon@nikanor.nu>
> > ---
> >   drivers/staging/pi433/pi433_if.h  | 5 +++++
> >   drivers/staging/pi433/rf69_enum.h | 5 -----
> >   2 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> > index bcfe29840889..c8697d144e2b 100644
> > --- a/drivers/staging/pi433/pi433_if.h
> > +++ b/drivers/staging/pi433/pi433_if.h
> > @@ -37,6 +37,11 @@
> >   /*---------------------------------------------------------------------------*/
> > +enum option_on_off {
> > +	OPTION_OFF,
> > +	OPTION_ON
> > +};
> > +
> >   /* IOCTL structs and commands */
> >   /**
> > diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h
> > index b0715b4eb6ac..4e64e38ae4ff 100644
> > --- a/drivers/staging/pi433/rf69_enum.h
> > +++ b/drivers/staging/pi433/rf69_enum.h
> > @@ -18,11 +18,6 @@
> >   #ifndef RF69_ENUM_H
> >   #define RF69_ENUM_H
> > -enum option_on_off {
> > -	OPTION_OFF,
> > -	OPTION_ON
> > -};
> > -
> >   enum mode {
> >   	mode_sleep,
> >   	standby,
> > 
> 
> Hi Simon,
> 
> sorry - I have one more question.
> 
> Why do you want to get rid of the enum option_on_off in rf69_enum.h. I
> generated that file just to store the enums.
> 
> Now we have one enum at an other place...

No need to have lots of .h files.   This is just a simple driver, it
should only have 1 .h file at most (for anything needed by userspace).

So moving these all into one file is good.

thanks,

greg k-h