Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750899AbdLGGr3 (ORCPT ); Thu, 7 Dec 2017 01:47:29 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50056 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbdLGGr1 (ORCPT ); Thu, 7 Dec 2017 01:47:27 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4B8F9607E8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 6 Dec 2017 22:47:23 -0800 From: Stephen Boyd To: Chunyan Zhang Cc: Michael Turquette , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Mark Brown , Xiaolong Zhang , Ben Li , Orson Zhai , Chunyan Zhang Subject: Re: [PATCH V6 01/12] drivers: move clock common macros out from vendor directories Message-ID: <20171207064723.GV4283@codeaurora.org> References: <20171127100115.20655-1-chunyan.zhang@spreadtrum.com> <20171127100115.20655-2-chunyan.zhang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127100115.20655-2-chunyan.zhang@spreadtrum.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2811 Lines: 91 On 11/27, Chunyan Zhang wrote: > These macros are used by more than one SoC vendor platforms, avoid to > have many copies of these code, this patch moves them to the common > clock directory which every clock drivers can access to. > > Signed-off-by: Chunyan Zhang > --- > drivers/clk/clk_common.h | 60 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 drivers/clk/clk_common.h > > diff --git a/drivers/clk/clk_common.h b/drivers/clk/clk_common.h > new file mode 100644 > index 0000000..21e93d2 > --- /dev/null > +++ b/drivers/clk/clk_common.h > @@ -0,0 +1,60 @@ > +/* > + * drivers/clk/clk_common.h We don't need this in the file too. Please remove this line. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ > + > +#ifndef _CLK_COMMON_H_ > +#define _CLK_COMMON_H_ > + > +#include Maybe these macros should just go into clk-provider.h? > + > +#define CLK_HW_INIT(_name, _parent, _ops, _flags) \ > + (&(struct clk_init_data) { \ > + .flags = _flags, \ > + .name = _name, \ > + .parent_names = (const char *[]) { _parent }, \ > + .num_parents = 1, \ > + .ops = _ops, \ > + }) Hopefully we don't extend the init structure anymore to have something else. I guess we'll do something if that happens. > + > +#define CLK_HW_INIT_PARENTS(_name, _parents, _ops, _flags) \ > + (&(struct clk_init_data) { \ > + .flags = _flags, \ > + .name = _name, \ > + .parent_names = _parents, \ > + .num_parents = ARRAY_SIZE(_parents), \ > + .ops = _ops, \ > + }) > + > +#define CLK_HW_INIT_NO_PARENT(_name, _ops, _flags) \ > + (&(struct clk_init_data) { \ > + .flags = _flags, \ > + .name = _name, \ > + .parent_names = NULL, \ > + .num_parents = 0, \ > + .ops = _ops, \ > + }) > + > +#define CLK_FIXED_FACTOR(_struct, _name, _parent, \ > + _div, _mult, _flags) \ > + struct clk_fixed_factor _struct = { \ > + .div = _div, \ > + .mult = _mult, \ > + .hw.init = CLK_HW_INIT(_name, \ > + _parent, \ > + &clk_fixed_factor_ops, \ > + _flags), \ > + } > + > +#define CLK_FIXED_RATE(_struct, _name, _flags, \ > + _fixed_rate, _fixed_accuracy) \ > + struct clk_fixed_rate _struct = { \ > + .fixed_rate = _fixed_rate, \ > + .fixed_accuracy = _fixed_accuracy, \ > + .hw.init = CLK_HW_INIT_NO_PARENT(_name, \ > + &clk_fixed_rate_ops, \ > + _flags), \ > + } Maybe don't add this one? Usually fixed rate clks come from DT. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project