Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430AbdLGJEf (ORCPT ); Thu, 7 Dec 2017 04:04:35 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:44411 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376AbdLGJEc (ORCPT ); Thu, 7 Dec 2017 04:04:32 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Thu, 07 Dec 2017 09:59:43 +0100 From: Stefan Agner To: shawnguo@kernel.org, kernel@pengutronix.de Cc: fabio.estevam@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/9] ARM: dts: imx7-colibri: add MCP2515 CAN controller In-Reply-To: <20171206153005.6144-8-stefan@agner.ch> References: <20171206153005.6144-1-stefan@agner.ch> <20171206153005.6144-8-stefan@agner.ch> Message-ID: User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2982 Lines: 105 On 2017-12-06 16:30, Stefan Agner wrote: > The Colibri Evaluation Carrier Board provides a MCP2515 CAN > controller connected via SPI. Note that the i.MX 7 provides > an internal CAN controller which is much better suited for CAN > operations. Using the MCP2515 with a Colibri iMX7 module is > mainly useful to test the SPI interface. > > Signed-off-by: Stefan Agner > --- > arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 25 +++++++++++++++++++++++++ > arch/arm/boot/dts/imx7-colibri.dtsi | 14 +++++++++++++- > 2 files changed, 38 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > index 87c23b769a08..3d6c282dd258 100644 > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > @@ -45,6 +45,13 @@ > stdout-path = "serial0:115200n8"; > }; > > + /* fixed crystal dedicated to mpc258x */ > + clk16m: clk16m { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <16000000>; > + }; > + > panel: panel { > compatible = "edt,et057090dhu"; > backlight = <&bl>; > @@ -99,6 +106,24 @@ > status = "okay"; > }; > > +&ecspi3 { > + status = "okay"; > + > + mcp258x0: mcp258x@0 { Just realized that this is somewhat bogus, this should be "mcp2515: can@0". -- Stefan > + compatible = "microchip,mcp2515"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_can_int>; > + reg = <0>; > + clocks = <&clk16m>; > + interrupt-parent = <&gpio5>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + spi-max-frequency = <10000000>; > + vdd-supply = <®_3v3>; > + xceiver-supply = <®_5v0>; > + status = "okay"; > + }; > +}; > + > &fec1 { > status = "okay"; > }; > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > b/arch/arm/boot/dts/imx7-colibri.dtsi > index 689ff6822634..e1c6da0a65e4 100644 > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > @@ -92,6 +92,13 @@ > cpu-supply = <®_DCDC2>; > }; > > +&ecspi3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ecspi3 &pinctrl_ecspi3_cs>; > + num-cs = <1>; > + cs-gpios = <&gpio4 11 GPIO_ACTIVE_HIGH>; > +}; > + > &fec1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_enet1>; > @@ -313,7 +320,6 @@ > fsl,pins = < > MX7D_PAD_ENET1_RGMII_RD3__GPIO7_IO3 0x74 /* SODIMM 55 */ > MX7D_PAD_ENET1_RGMII_RD2__GPIO7_IO2 0x74 /* SODIMM 63 */ > - MX7D_PAD_SD1_RESET_B__GPIO5_IO2 0X14 /* SODIMM 73 */ > MX7D_PAD_SAI1_RX_SYNC__GPIO6_IO16 0x14 /* SODIMM 77 */ > MX7D_PAD_EPDC_DATA09__GPIO2_IO9 0x14 /* SODIMM 89 */ > MX7D_PAD_EPDC_DATA08__GPIO2_IO8 0x74 /* SODIMM 91 */ > @@ -400,6 +406,12 @@ > >; > }; > > + pinctrl_can_int: can-int-grp { > + fsl,pins = < > + MX7D_PAD_SD1_RESET_B__GPIO5_IO2 0X14 /* SODIMM 73 */ > + >; > + }; > + > pinctrl_enet1: enet1grp { > fsl,pins = < > MX7D_PAD_ENET1_CRS__GPIO7_IO14 0x14