Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbdLGJKd (ORCPT ); Thu, 7 Dec 2017 04:10:33 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:38658 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdLGJKa (ORCPT ); Thu, 7 Dec 2017 04:10:30 -0500 X-Google-Smtp-Source: AGs4zMYqHtPqfviXYBYjsmrAFjAlSxFloU+os5qVCEAnyweZie6XmRxp07NXRMAEzDfJllhGkqFl2nblskh+oAhJ7dA= MIME-Version: 1.0 In-Reply-To: <20171205144647.17594-1-quentin.schulz@free-electrons.com> References: <20171205144647.17594-1-quentin.schulz@free-electrons.com> From: Linus Walleij Date: Thu, 7 Dec 2017 10:10:29 +0100 Message-ID: Subject: Re: [PATCH v5 00/11] add pinmuxing support for pins in AXP209 and AXP813 PMICs To: Quentin Schulz Cc: Rob Herring , Mark Rutland , Chen-Yu Tsai , Russell King , Maxime Ripard , Lee Jones , linux-gpio@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Linux ARM , Thomas Petazzoni , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1140 Lines: 27 On Tue, Dec 5, 2017 at 3:46 PM, Quentin Schulz wrote: > The AXP209 and AXP813 PMICs have several pins (respectively 3 and 2) that can > be used either as GPIOs or for other purposes (ADC or LDO here). > > We already have a GPIO driver for the GPIO use of those pins on the AXP209. > Let's "upgrade" this driver to support all the functions these pins can have. > > Then we add support to this driver for the AXP813 which is slighlty different > (basically a different offset in two registers and one less pin). > > I suggest patches 1 to 8 go through Linus's tree and 9 via Lee's. > > v5: > - add reference to pinctrl dt-bindings in driver's dt-binding, > - add statement that this driver employs per-pin muxing pattern, > - add a patch on top of the patch series to fix checkpatch warnings, > - add a few information to the Kconfig to make checkpatch happy, I have applied patches 1-8 to an immutable branch in the GPIO tree, then merged that into the GPIO "devel" branch as well as the pinctrl "devel" branch so we can develop the driver in the pinctrl tree henceforth. Yours, Linus Walleij