Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbdLGJRW (ORCPT ); Thu, 7 Dec 2017 04:17:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:39250 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbdLGJRR (ORCPT ); Thu, 7 Dec 2017 04:17:17 -0500 Message-ID: <1512638231.17062.5.camel@suse.com> Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() From: Oliver Neukum To: Greg Kroah-Hartman , Geert Uytterhoeven Cc: Dmitry Fleytman , Daniel Drake , Eugene Korenevsky , Johan Hovold , Mathias Nyman , Peter Chen , Dan Carpenter , Joe Perches , =?ISO-8859-1?Q?G=FCnter_R=F6ck?= , Alan Stern , SF Markus Elfring , "kernel-janitors@vger.kernel.org" , LKML , USB list Date: Thu, 07 Dec 2017 10:17:11 +0100 In-Reply-To: <20171207085611.GA7110@kroah.com> References: <20171207083542.gohu4z3v4fp7gvsu@mwanda> <20171207085611.GA7110@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 17 Am Donnerstag, den 07.12.2017, 09:56 +0100 schrieb Greg Kroah-Hartman: > On Thu, Dec 07, 2017 at 09:45:38AM +0100, Geert Uytterhoeven wrote: > > > > A few comments (this is in response to a patch from Markus, so there have > > to be lots of questions and uncertainties ;-) > > Note, because of the patch author, I'm not applying it no matter what, > so this discussion is really going nowhere. We really need to come to a consensus on that question. If those additional messages really are redundant, we could save memory deleting them. Or alternatively, if they are not and we need to know which device is hit, we should centralize that reporting and tell the VM subsystem not the dump a stack trace. Regards Oliver