Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750981AbdLGJbc (ORCPT ); Thu, 7 Dec 2017 04:31:32 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:43921 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbdLGJbb (ORCPT ); Thu, 7 Dec 2017 04:31:31 -0500 X-Google-Smtp-Source: AGs4zMYwlAAl8kfyfFUMz0qDXiyBWqHROY9Oi7PbxvOLAvbLZNzvkEfkTDnCq4AJwDtCy5tijQSyRA== Date: Thu, 7 Dec 2017 09:31:27 +0000 From: Lee Jones To: Gwendal Grignou Cc: Thierry Escande , Benson Leung , Jonathan Cameron , Enric Balletbo i Serra , Linux Kernel Subject: Re: [PATCH v5 3/3] platform/chrome: Register cros_ec_accel_legacy driver Message-ID: <20171207093127.735w6kk44f6unukl@dell> References: <1512135743-16529-1-git-send-email-thierry.escande@collabora.com> <1512135743-16529-4-git-send-email-thierry.escande@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 33 On Fri, 01 Dec 2017, Gwendal Grignou wrote: > Checked against 3bf98755f9c670c5c10ca05cba22848d65117cb2 (CHROMIUM: > iio: accel: Add cros_ec_accel_legacy driver) > > Fixup f2b141a242e59017dbc774dc916748670a41da0b (FIXUP: CHROMIUM: iio: > accel: Add cros_ec_accel_legacy driver) is required for devices with > secondary Embedded Controllers. Is that an Ack or a NAck? And pleeeeeease don't top post. > On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande > wrote: > > With this patch, the cros_ec_ctl driver will register the legacy > > accelerometer driver (named cros_ec_accel_legacy) if it fails to > > register sensors through the usual path cros_ec_sensors_register(). > > This legacy device is present on Chromebook devices with older EC > > firmware only supporting deprecated EC commands (Glimmer based devices). > > > > Signed-off-by: Thierry Escande > > --- > > drivers/mfd/cros_ec_dev.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) [...] -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog