From: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
To: "'Philippe Ombredanne'" <pombredanne@nexb.com>
CC: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        Hyun Kwon <hyunk@xilinx.com>
Subject: RE: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU
 logicoreIP init driver
Thread-Topic: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU
 logicoreIP init driver
Thread-Index: AQHTbb/vvsNWt82zs0iPUUhWqjiWdqM3qqsAgAAGTSA=
Date: Thu, 7 Dec 2017 10:30:45 +0000
Message-ID: <BY2PR0201MB187907246257CACE5D206F0EC1330@BY2PR0201MB1879.namprd02.prod.outlook.com>
References: <1512474212-12803-1-git-send-email-dshah@xilinx.com>
 <CAOFm3uH0iqr-vyF8Zj7-UfjGihprKAV-YjpnJqAOmqarGUh2-A@mail.gmail.com>
In-Reply-To: <CAOFm3uH0iqr-vyF8Zj7-UfjGihprKAV-YjpnJqAOmqarGUh2-A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 43b858e5-44cf-4334-709f-08d53d5d9364
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2017 10:30:45.5316
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1004
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vB7AVBRf021985
Content-Length: 1559
Lines: 47


> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@nexb.com]
> Sent: Thursday, December 07, 2017 2:07 AM
> To: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; LKML <linux-kernel@vger.kernel.org>;
> michal.simek@xilinx.com; Hyun Kwon <hyunk@xilinx.com>; Dhaval
> Rajeshbhai Shah <DSHAH@xilinx.com>
> Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU
> logicoreIP init driver
> 
> Daval,
> 
> On Tue, Dec 5, 2017 at 12:43 PM, Dhaval Shah <dhaval.shah@xilinx.com>
> wrote:
> > Xilinx ZYNQMP VCU Init driver is based on the new LogiCoreIP design
> > created. This driver will provide the api which can be used by the
> > encoder and decoder driver to get the configured value.
> >
> > Signed-off-by: Dhaval Shah <dshah@xilinx.com>
> []
> > diff --git a/drivers/misc/xlnx_vcu.c b/drivers/misc/xlnx_vcu.c new
> > file mode 100644 index 0000000..373f7f9
> > --- /dev/null
> > +++ b/drivers/misc/xlnx_vcu.c
> > @@ -0,0 +1,664 @@
> > +/*
> > + * Xilinx VCU Init
> > + *
> > + * Copyright (C) 2016 - 2017 Xilinx, Inc.
> > + *
> > + * Contacts   Dhaval Shah <dshah@xilinx.com>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0
> > + */
> 
> The SPDX id should be on the first line with a C++ // style comment instead as
> requested by Linus.
I will take care of this Changes as also suggested by the Greg k-h as well once get the ACK for the remaining reply from the Greg k-h.

Thanks & Regards,
Dhaval
> --
> Cordially
> Philippe Ombredanne