Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbdLGKrw (ORCPT ); Thu, 7 Dec 2017 05:47:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42554 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbdLGKrv (ORCPT ); Thu, 7 Dec 2017 05:47:51 -0500 Date: Thu, 7 Dec 2017 11:47:57 +0100 From: Greg Kroah-Hartman To: Dhaval Rajeshbhai Shah Cc: "'Philippe Ombredanne'" , Arnd Bergmann , LKML , "michal.simek@xilinx.com" , Hyun Kwon Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver Message-ID: <20171207104757.GA27343@kroah.com> References: <1512474212-12803-1-git-send-email-dshah@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1764 Lines: 47 On Thu, Dec 07, 2017 at 10:30:45AM +0000, Dhaval Rajeshbhai Shah wrote: > > > > -----Original Message----- > > From: Philippe Ombredanne [mailto:pombredanne@nexb.com] > > Sent: Thursday, December 07, 2017 2:07 AM > > To: Dhaval Rajeshbhai Shah > > Cc: Arnd Bergmann ; Greg Kroah-Hartman > > ; LKML ; > > michal.simek@xilinx.com; Hyun Kwon ; Dhaval > > Rajeshbhai Shah > > Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU > > logicoreIP init driver > > > > Daval, > > > > On Tue, Dec 5, 2017 at 12:43 PM, Dhaval Shah > > wrote: > > > Xilinx ZYNQMP VCU Init driver is based on the new LogiCoreIP design > > > created. This driver will provide the api which can be used by the > > > encoder and decoder driver to get the configured value. > > > > > > Signed-off-by: Dhaval Shah > > [] > > > diff --git a/drivers/misc/xlnx_vcu.c b/drivers/misc/xlnx_vcu.c new > > > file mode 100644 index 0000000..373f7f9 > > > --- /dev/null > > > +++ b/drivers/misc/xlnx_vcu.c > > > @@ -0,0 +1,664 @@ > > > +/* > > > + * Xilinx VCU Init > > > + * > > > + * Copyright (C) 2016 - 2017 Xilinx, Inc. > > > + * > > > + * Contacts Dhaval Shah > > > + * > > > + * SPDX-License-Identifier: GPL-2.0 > > > + */ > > > > The SPDX id should be on the first line with a C++ // style comment instead as > > requested by Linus. > I will take care of this Changes as also suggested by the Greg k-h as well once get the ACK for the remaining reply from the Greg k-h. Don't wait for me, my queue is really long, if you have fixes that you know you need to make, make them! greg k-h