Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752969AbdLGLBv (ORCPT ); Thu, 7 Dec 2017 06:01:51 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:41550 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898AbdLGLBs (ORCPT ); Thu, 7 Dec 2017 06:01:48 -0500 X-Google-Smtp-Source: AGs4zMZy5TJmVV10RRhsCIdNvRItJwko/XVPDrzIk3Ld9DcbCYdT1TewEGRiq4Qsm2gHZ+EzJ8ZGbg== Subject: Re: [PATCH v2] clocksource: tcb_clksrc: Fix clock speed message To: Romain Izard , Nicolas Ferre Cc: Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20171201122233.21828-1-romain.izard.pro@gmail.com> From: Daniel Lezcano Message-ID: <6f3d309e-2e71-3f60-5910-0d8b1f051836@linaro.org> Date: Thu, 7 Dec 2017 12:01:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171201122233.21828-1-romain.izard.pro@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1628 Lines: 45 On 01/12/2017 13:22, Romain Izard wrote: > The clock speed displayed at boot in an information message was 500 kHz > too high compared to its real value. As the value is not used anywhere, > there is no functional impact. > > Fix the rounding formula to display the correct value. > > Signed-off-by: Romain Izard > --- > v2: rebase over v4.15-rc1 > > There is no specified maintainer for this file, only supporters. That is not correct, it defaults to Thomas and me, the maintainers of drivers/clocksource :) > Nicolas, could you pick this through the at91 tree as the TCB block > is an AT91 peripheral ? Nicolas, do you agree with this change ? If yes, I will take it. > drivers/clocksource/tcb_clksrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c > index 9de47d4d2d9e..43f4d5c4d6fa 100644 > --- a/drivers/clocksource/tcb_clksrc.c > +++ b/drivers/clocksource/tcb_clksrc.c > @@ -384,7 +384,7 @@ static int __init tcb_clksrc_init(void) > > printk(bootinfo, clksrc.name, CONFIG_ATMEL_TCB_CLKSRC_BLOCK, > divided_rate / 1000000, > - ((divided_rate + 500000) % 1000000) / 1000); > + ((divided_rate % 1000000) + 500) / 1000); > if (tc->tcb_config && tc->tcb_config->counter_width == 32) { > /* use apropriate function to read 32 bit counter */ > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog