Date: Thu, 7 Dec 2017 05:17:37 -0600 (CST)
From: Christopher Lameter <cl@linux.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
cc: Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: Merge adjacent debug sections
In-Reply-To: <1512641932-5221-1-git-send-email-geert+renesas@glider.be>
Message-ID: <alpine.DEB.2.20.1712070515490.7218@nuc-kabylake>
References: <1512641932-5221-1-git-send-email-geert+renesas@glider.be>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 497
Lines: 18

On Thu, 7 Dec 2017, Geert Uytterhoeven wrote:

> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1569,9 +1569,6 @@ static void dump_line(char *data, int offset, int limit)
>  		}
>  	}
>  }
> -#endif
> -
> -#if DEBUG


Hmmm... This may match at other places. Also there are a lot of #ifdef
DEBUG / #else in that section of the code. Maybe better leave as is? Or
generally rework this into a single #ifdef DEBUG section with all the
debugging code in it and an #else section with all the empty functions.