Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752898AbdLGLmI (ORCPT ); Thu, 7 Dec 2017 06:42:08 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:33050 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752670AbdLGLmH (ORCPT ); Thu, 7 Dec 2017 06:42:07 -0500 From: Philippe CORNU To: Brian Norris , Nickey Yang CC: "robh+dt@kernel.org" , "heiko@sntech.de" , "mark.rutland@arm.com" , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-rockchip@lists.infradead.org" , "laurent.pinchart@ideasonboard.com" , "seanpaul@chromium.org" , "mka@chromium.org" , "hoegsberg@gmail.com" , "architt@codeaurora.org" , Yannick FERTRE , "hl@rock-chips.com" , "zyw@rock-chips.com" , "xbl@rock-chips.com" Subject: Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata Thread-Topic: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata Thread-Index: AQHTbnHXhs72dibmp0K9oIm1u2wVyqM2x5kAgADrVYA= Date: Thu, 7 Dec 2017 11:41:17 +0000 Message-ID: References: <1512551301-12946-1-git-send-email-nickey.yang@rock-chips.com> <1512551301-12946-2-git-send-email-nickey.yang@rock-chips.com> <20171206213858.GA14257@google.com> In-Reply-To: <20171206213858.GA14257@google.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.49] Content-Type: text/plain; charset="utf-8" Content-ID: <829467ED1C4E88438CBB5BF9AF17962D@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-07_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB7BgHdr002482 Content-Length: 1845 Lines: 58 Hi Nickey, platform_set_drvdata() is still missing in your version. Thanks, Philippe :-) On 12/06/2017 10:39 PM, Brian Norris wrote: > On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote: >> From: Brian Norris >> >> Bridge drivers/helpers shouldn't be clobbering the drvdata, since a >> parent driver might need to own this. Instead, let's return our >> 'dw_mipi_dsi' object and have callers pass that back to us for removal. >> >> Signed-off-by: Brian Norris >> Signed-off-by: Nickey Yang >> Link:https://patchwork.kernel.org/patch/10078493/ >> >> --- >> Changes >> >> v4: >> - Add From tag,update subject line >> - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove" >> in this piece together. >> >> v5: >> - remove Review & Ack tag >> - fix remove() directly referencing the static >> dw_mipi_dsi_stm_plat_data struct. > > You've gotten this back into basically the shape I sent v1 in, so I > guess this deserves an: > > Acked-by: Brian Norris > > :) > > Only net changes: you renamed the 'dsi' field to 'dmd' (Dwc Mipi > Device?), and my 'return 0' changed back to the original 'return ret' at > the end of probe(). Doesn't make any functional difference, so fine with > me. > > If everybody's just as happy with this as with the first > version...should it just be applied now, regardless of the status of the > next 2 patches? Could help reduce the discussion (and confusion) > surface. > > Regards, > Brian > >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 36 ++++++++++----------------- >> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 10 +++++--- >> include/drm/bridge/dw_mipi_dsi.h | 17 ++++++++----- >> 3 files changed, 30 insertions(+), 33 deletions(-) > ... >