Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753120AbdLGMBl (ORCPT ); Thu, 7 Dec 2017 07:01:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:40992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951AbdLGMBk (ORCPT ); Thu, 7 Dec 2017 07:01:40 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8670021882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jlayton@kernel.org Message-ID: <1512648098.1350.6.camel@kernel.org> Subject: Re: [PATCH] integrity: get rid of unneeded initializations in integrity_iint_cache entries From: Jeff Layton To: Mimi Zohar , "Serge E. Hallyn" Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Date: Thu, 07 Dec 2017 07:01:38 -0500 In-Reply-To: <1499370226.3130.36.camel@linux.vnet.ibm.com> References: <20170706145421.13223-1-jlayton@kernel.org> <20170706150424.GA21489@mail.hallyn.com> <1499370226.3130.36.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.2 (3.26.2-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1815 Lines: 63 On Thu, 2017-07-06 at 15:43 -0400, Mimi Zohar wrote: > On Thu, 2017-07-06 at 10:04 -0500, Serge E. Hallyn wrote: > > Quoting Jeff Layton (jlayton@kernel.org): > > > From: Jeff Layton > > > > > > The init_once routine memsets the whole object to 0, and then > > > explicitly sets some of the fields to 0 again. Just remove the explicit > > > initializations. > > > > > > Signed-off-by: Jeff Layton > > > > Reviewed-by: Serge Hallyn > > Thanks, queued. > > Mimi > Hi Mimi, I notice that this patch hasn't made the last couple of releases. Was it dropped for some reason? Thanks, Jeff > > > > > --- > > > security/integrity/iint.c | 3 --- > > > 1 file changed, 3 deletions(-) > > > > > > diff --git a/security/integrity/iint.c b/security/integrity/iint.c > > > index 6fc888ca468e..187b7cb378be 100644 > > > --- a/security/integrity/iint.c > > > +++ b/security/integrity/iint.c > > > @@ -153,14 +153,11 @@ static void init_once(void *foo) > > > struct integrity_iint_cache *iint = foo; > > > > > > memset(iint, 0, sizeof(*iint)); > > > - iint->version = 0; > > > - iint->flags = 0UL; > > > iint->ima_file_status = INTEGRITY_UNKNOWN; > > > iint->ima_mmap_status = INTEGRITY_UNKNOWN; > > > iint->ima_bprm_status = INTEGRITY_UNKNOWN; > > > iint->ima_read_status = INTEGRITY_UNKNOWN; > > > iint->evm_status = INTEGRITY_UNKNOWN; > > > - iint->measured_pcrs = 0; > > > } > > > > > > static int __init integrity_iintcache_init(void) > > > -- > > > 2.13.0 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- Jeff Layton