Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754836AbdLGNCZ (ORCPT ); Thu, 7 Dec 2017 08:02:25 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:44182 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754801AbdLGNCU (ORCPT ); Thu, 7 Dec 2017 08:02:20 -0500 X-Google-Smtp-Source: AGs4zMbVLB12XjtKK4lNpTQInZgZaw0MAunTX3d/eFNAGtLRvPR7XEWVpq/sBAAxnFo15lMimdtOF1RPUL545XB8JPA= MIME-Version: 1.0 In-Reply-To: <1512647169-11796-1-git-send-email-ben.whitten@lairdtech.com> References: <1512647169-11796-1-git-send-email-ben.whitten@lairdtech.com> From: Philippe Ombredanne Date: Thu, 7 Dec 2017 14:01:39 +0100 Message-ID: Subject: Re: [PATCH v3] leds: trigger: Introduce a NETDEV trigger To: Ben Whitten Cc: rpurdie@rpsys.net, Pavel Machek , jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org, LKML , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1732 Lines: 58 Ben, On Thu, Dec 7, 2017 at 12:46 PM, Ben Whitten wrote: > From: Ben Whitten > > This commit introduces a NETDEV trigger for named device > activity. Available triggers are link, rx, and tx. > > Signed-off-by: Ben Whitten [] > --- /dev/null > +++ b/drivers/leds/trigger/ledtrig-netdev.c > @@ -0,0 +1,503 @@ > +/* > + * LED Kernel Netdev Trigger > + * > + * Toggles the LED to reflect the link and traffic state of a named net device > + * > + * Copyright 2017 Ben Whitten > + * > + * Copyright 2007 Oliver Jowett > + * > + * Derived from ledtrig-timer.c which is: > + * Copyright 2005-2006 Openedhand Ltd. > + * Author: Richard Purdie > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + */ Have you considered using the new SPDX id instead ? See Thomas doc patches and Greg and Linus comments on the topic Here this would likely come out this way (yes, using a C++ comment at the top): > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * LED Kernel Netdev Trigger > + * > + * Toggles the LED to reflect the link and traffic state of a named net device > + * > + * Copyright 2017 Ben Whitten > + * > + * Copyright 2007 Oliver Jowett > + * > + * Derived from ledtrig-timer.c which is: > + * Copyright 2005-2006 Openedhand Ltd. > + * Author: Richard Purdie > + * > + */ This is cleaner and simpler, don't you think? -- Cordially Philippe Ombredanne