Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932101AbdLGNGR (ORCPT ); Thu, 7 Dec 2017 08:06:17 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:38994 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754958AbdLGND6 (ORCPT ); Thu, 7 Dec 2017 08:03:58 -0500 Subject: Re: [PATCH 4.9 037/109] dmaengine: stm32-dma: Set correct args number for DMA request from DT To: Greg Kroah-Hartman , CC: , Mboumba Cedric Madianga , Vinod Koul , Sasha Levin , Pierre Yves MORDRET References: <20171207125634.631485452@linuxfoundation.org> <20171207125638.879250123@linuxfoundation.org> From: Ludovic BARRE Message-ID: Date: Thu, 7 Dec 2017 14:03:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171207125638.879250123@linuxfoundation.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG6NODE1.st.com (10.75.127.16) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-07_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1672 Lines: 54 add Pierre-yves Mordret acked-by: Ludovic BARRE On 12/07/2017 01:56 PM, Greg Kroah-Hartman wrote: > 4.9-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: M'boumba Cedric Madianga > > > [ Upstream commit 7e96304d99477de1f70db42035071e56439da817 ] > > This patch sets the right number of arguments to be used for DMA clients > which request channels from DT. > > Signed-off-by: M'boumba Cedric Madianga > Reviewed-by: Ludovic BARRE > Signed-off-by: Vinod Koul > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman > --- > drivers/dma/stm32-dma.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > --- a/drivers/dma/stm32-dma.c > +++ b/drivers/dma/stm32-dma.c > @@ -976,21 +976,18 @@ static struct dma_chan *stm32_dma_of_xla > struct stm32_dma_chan *chan; > struct dma_chan *c; > > - if (dma_spec->args_count < 3) > + if (dma_spec->args_count < 4) > return NULL; > > cfg.channel_id = dma_spec->args[0]; > cfg.request_line = dma_spec->args[1]; > cfg.stream_config = dma_spec->args[2]; > - cfg.threshold = 0; > + cfg.threshold = dma_spec->args[3]; > > if ((cfg.channel_id >= STM32_DMA_MAX_CHANNELS) || (cfg.request_line >= > STM32_DMA_MAX_REQUEST_ID)) > return NULL; > > - if (dma_spec->args_count > 3) > - cfg.threshold = dma_spec->args[3]; > - > chan = &dmadev->chan[cfg.channel_id]; > > c = dma_get_slave_channel(&chan->vchan.chan); > >