Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754082AbdLGM70 (ORCPT ); Thu, 7 Dec 2017 07:59:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:32781 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbdLGM7X (ORCPT ); Thu, 7 Dec 2017 07:59:23 -0500 Date: Thu, 7 Dec 2017 13:58:05 +0100 From: Cyril Hrubis To: John Hubbard Cc: Michal Hocko , Michael Kerrisk , linux-man , linux-api@vger.kernel.org, Michael Ellerman , linux-mm@kvack.org, LKML , linux-arch@vger.kernel.org, Jann Horn , Matthew Wilcox Subject: Re: [PATCH v2] mmap.2: MAP_FIXED updated documentation Message-ID: <20171207125805.GA1210@rei.lan> References: <20171204021411.4786-1-jhubbard@nvidia.com> <20171204105549.GA31332@rei> <20171205070510.aojohhvixijk3i27@dhcp22.suse.cz> <2cff594a-b481-269d-dd91-ff2cc2f4100a@nvidia.com> <20171206100118.GA13979@rei> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1747 Lines: 40 Hi! > >> (It does seem unfortunate that the man page cannot help the programmer > >> actually write correct code here. He or she is forced to read the kernel > >> implementation, in order to figure out the true alignment rules. I was > >> hoping we could avoid that.) > > > > It would be nice if we had this information exported somehere so that we > > do not have to rely on per-architecture ifdefs. > > > > What about adding MapAligment or something similar to the /proc/meminfo? > > > > What's the use case you envision for that? I don't see how that would be > better than using SHMLBA, which is available at compiler time. Because > unless someone expects to be able to run an app that was compiled for > Arch X, on Arch Y (surely that's not requirement here?), I don't see how > the run-time check is any better. I guess that some kind of compile time constant in uapi headers will do as well, I'm really open to any solution that would expose this constant as some kind of official API. There is one problem with using SHMLBA, there are more than one libc implementations and at least two of them (bionic and klibc) does not implement the SysV IPC at all. I know that the chances that you are writing a program that requires MAP_FIXED, is compiled against alternative libc, and expected to run on less common architectures are pretty slim. On the other hand I do not see a reason why this cannot be done properly, this is just about exporting one simple constant to userspace after all. > Or maybe you're thinking that since the SHMLBA cannot be put in the man > pages, we could instead provide MapAlignment as sort of a different > way to document the requirement? This is my intention as well. -- Cyril Hrubis chrubis@suse.cz