Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753593AbdLGOTv (ORCPT ); Thu, 7 Dec 2017 09:19:51 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:46979 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbdLGOTs (ORCPT ); Thu, 7 Dec 2017 09:19:48 -0500 X-Google-Smtp-Source: AGs4zMYMamb4Cl2F1ks/K0XiKXtz+nYour+JkgKsykiRx9WL4a3Py4fgT3ViAylpCQS4z/IFmaQyo17qavOkEnM4Msc= MIME-Version: 1.0 In-Reply-To: References: <1512647169-11796-1-git-send-email-ben.whitten@lairdtech.com> From: Ben Whitten Date: Thu, 7 Dec 2017 14:19:46 +0000 X-Google-Sender-Auth: QmoG2VWUBHdz9R0AJ4XMWPY58bk Message-ID: Subject: Re: [PATCH v3] leds: trigger: Introduce a NETDEV trigger To: Philippe Ombredanne Cc: rpurdie@rpsys.net, Pavel Machek , Jacek Anaszewski , linux-leds@vger.kernel.org, LKML , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1943 Lines: 62 Philippe, On 7 December 2017 at 13:01, Philippe Ombredanne wrote: > Ben, > > On Thu, Dec 7, 2017 at 12:46 PM, Ben Whitten wrote: >> From: Ben Whitten >> >> This commit introduces a NETDEV trigger for named device >> activity. Available triggers are link, rx, and tx. >> >> Signed-off-by: Ben Whitten > [] >> --- /dev/null >> +++ b/drivers/leds/trigger/ledtrig-netdev.c >> @@ -0,0 +1,503 @@ >> +/* >> + * LED Kernel Netdev Trigger >> + * >> + * Toggles the LED to reflect the link and traffic state of a named net device >> + * >> + * Copyright 2017 Ben Whitten >> + * >> + * Copyright 2007 Oliver Jowett >> + * >> + * Derived from ledtrig-timer.c which is: >> + * Copyright 2005-2006 Openedhand Ltd. >> + * Author: Richard Purdie >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + */ > > Have you considered using the new SPDX id instead ? See Thomas doc > patches and Greg and Linus comments on the topic > Here this would likely come out this way (yes, using a C++ comment at the top): > >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * LED Kernel Netdev Trigger >> + * >> + * Toggles the LED to reflect the link and traffic state of a named net device >> + * >> + * Copyright 2017 Ben Whitten >> + * >> + * Copyright 2007 Oliver Jowett >> + * >> + * Derived from ledtrig-timer.c which is: >> + * Copyright 2005-2006 Openedhand Ltd. >> + * Author: Richard Purdie >> + * >> + */ > > > This is cleaner and simpler, don't you think? Much cleaner. Thank you for the suggestion, I was unaware of this. Kind regards, Ben Whitten