Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899AbdLGOgA (ORCPT ); Thu, 7 Dec 2017 09:36:00 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:42772 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753453AbdLGOf7 (ORCPT ); Thu, 7 Dec 2017 09:35:59 -0500 Subject: Re: [PATCH] integrity: get rid of unneeded initializations in integrity_iint_cache entries From: Mimi Zohar To: Jeff Layton , "Serge E. Hallyn" Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Date: Thu, 07 Dec 2017 09:35:47 -0500 In-Reply-To: <1512648098.1350.6.camel@kernel.org> References: <20170706145421.13223-1-jlayton@kernel.org> <20170706150424.GA21489@mail.hallyn.com> <1499370226.3130.36.camel@linux.vnet.ibm.com> <1512648098.1350.6.camel@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17120714-0020-0000-0000-000003D5751C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120714-0021-0000-0000-0000426B0161 Message-Id: <1512657347.3527.48.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-07_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712070215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 30 On Thu, 2017-12-07 at 07:01 -0500, Jeff Layton wrote: > On Thu, 2017-07-06 at 15:43 -0400, Mimi Zohar wrote: > > On Thu, 2017-07-06 at 10:04 -0500, Serge E. Hallyn wrote: > > > Quoting Jeff Layton (jlayton@kernel.org): > > > > From: Jeff Layton > > > > > > > > The init_once routine memsets the whole object to 0, and then > > > > explicitly sets some of the fields to 0 again. Just remove the explicit > > > > initializations. > > > > > > > > Signed-off-by: Jeff Layton > > > > > > Reviewed-by: Serge Hallyn > > > > Thanks, queued. > > > > Mimi > > > > Hi Mimi, > > I notice that this patch hasn't made the last couple of releases. Was it > dropped for some reason? Thanks for the reminder.  I accidentally dropped it (and Sascha Hauer's patch).  The subject line is too long.  Assuming you don't object, I'll replace the "get rid of" with "removed" and queue the patch in the next-queued-testing branch. Mimi