From: Michael Frank <mflt1@micrologica.com.hk>
To: Russell King <rmk@arm.linux.org.uk>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: 2.5.75-mm1 yenta-socket lsPCI IRQ reads incorrect
Date: Mon, 14 Jul 2003 23:18:07 +0800
User-Agent: KMail/1.5.2
Cc: linux-kernel <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@suse.cz>,
       John Belmonte <jvb@prairienet.org>
References: <200307141333.03911.mflt1@micrologica.com.hk> <20030714150435.GB5118@gtf.org> <20030714162138.B31395@flint.arm.linux.org.uk>
In-Reply-To: <20030714162138.B31395@flint.arm.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200307142318.07232.mflt1@micrologica.com.hk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1531
Lines: 43

On Monday 14 July 2003 23:21, Russell King wrote:
> On Mon, Jul 14, 2003 at 11:04:35AM -0400, Jeff Garzik wrote:
> > On Mon, Jul 14, 2003 at 03:50:51PM +0100, Russell King wrote:

I'll give that patch a go tomorrow.

> > >  	yenta_allocate_resources(socket);
> > > +
> > > +	pci_save_state(dev, socket->saved_state);
> > >
> > >  	socket->cb_irq = dev->irq;
> >
> > This reminds me, PCI Express makes the PCI config area larger, going
> > from 256 bytes to either 4K or 64K IIRC.
> >
> > I wonder if we want new pci_{save,restore}_xstate functions?
> > Or change the pci_{save,restore}_state API now to work with larger
> > config areas?
>
> Maybe we really want an API where you can pass in the size of your
> buffer (which also determines how much gets saved) ?

Right, using the dword write function for 16 words or so is OK, but
rather clumsy for much more than that.

Regards
Michael
-- 
Powered by linux-2.5.75-mm1. Compiled with gcc-2.95-3 - mature and rock solid

My current linux related activities:
- 2.5 yenta_socket testing
- Test development and testing of swsusp for 2.4/2.5 and ACPI S3 of 2.5 kernel 
- Everyday usage of 2.5 kernel

More info on 2.5 kernel: http://www.codemonkey.org.uk/post-halloween-2.5.txt
More info on swsusp: http://sourceforge.net/projects/swsusp/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/