Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753433AbdLGPQ5 (ORCPT ); Thu, 7 Dec 2017 10:16:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:42034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108AbdLGPQz (ORCPT ); Thu, 7 Dec 2017 10:16:55 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDC8A218DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jlayton@kernel.org Message-ID: <1512659813.1350.18.camel@kernel.org> Subject: Re: [PATCH] integrity: get rid of unneeded initializations in integrity_iint_cache entries From: Jeff Layton To: Mimi Zohar , "Serge E. Hallyn" Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Date: Thu, 07 Dec 2017 10:16:53 -0500 In-Reply-To: <1512657347.3527.48.camel@linux.vnet.ibm.com> References: <20170706145421.13223-1-jlayton@kernel.org> <20170706150424.GA21489@mail.hallyn.com> <1499370226.3130.36.camel@linux.vnet.ibm.com> <1512648098.1350.6.camel@kernel.org> <1512657347.3527.48.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.2 (3.26.2-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 38 On Thu, 2017-12-07 at 09:35 -0500, Mimi Zohar wrote: > On Thu, 2017-12-07 at 07:01 -0500, Jeff Layton wrote: > > On Thu, 2017-07-06 at 15:43 -0400, Mimi Zohar wrote: > > > On Thu, 2017-07-06 at 10:04 -0500, Serge E. Hallyn wrote: > > > > Quoting Jeff Layton (jlayton@kernel.org): > > > > > From: Jeff Layton > > > > > > > > > > The init_once routine memsets the whole object to 0, and then > > > > > explicitly sets some of the fields to 0 again. Just remove the explicit > > > > > initializations. > > > > > > > > > > Signed-off-by: Jeff Layton > > > > > > > > Reviewed-by: Serge Hallyn > > > > > > Thanks, queued. > > > > > > Mimi > > > > > > > Hi Mimi, > > > > I notice that this patch hasn't made the last couple of releases. Was it > > dropped for some reason? > > Thanks for the reminder. I accidentally dropped it (and Sascha > Hauer's patch). The subject line is too long. Assuming you don't > object, I'll replace the "get rid of" with "removed" and queue the > patch in the next-queued-testing branch. > > Mimi > Sounds good. Thanks, -- Jeff Layton