Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754562AbdLGPcU (ORCPT ); Thu, 7 Dec 2017 10:32:20 -0500 Received: from conssluserg-05.nifty.com ([210.131.2.90]:42638 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbdLGPcT (ORCPT ); Thu, 7 Dec 2017 10:32:19 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com vB7FW9Io023434 X-Nifty-SrcIP: [209.85.217.170] X-Google-Smtp-Source: AGs4zMZ5qa4a4Iq5k1wIwJ6oiJ3zKkocA91U68aBgGeKCCn0oaTGuQiCY+W1SRVIP/bv/7kUiHiFX0sAmYJtCvvNG2I= MIME-Version: 1.0 In-Reply-To: References: <20171114123834.xsjiy2ynvott4gae@brain> <1511780854-7213-1-git-send-email-paolo.pisati@canonical.com> From: Masahiro Yamada Date: Fri, 8 Dec 2017 00:31:28 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] scripts/package: snap-pkg target To: Paolo Pisati Cc: Jim Davis , Michal Marek , Behan Webster , Matthias Kaehlcke , =?UTF-8?Q?Vin=C3=ADcius_Tinti?= , linux-kbuild , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 36 2017-12-07 3:14 GMT+09:00 Paolo Pisati : > On Wed, Dec 6, 2017 at 11:36 AM, Masahiro Yamada > wrote: >> Just one question to Paolo: >> >> If some change like firmware removal happens in the future, >> patching for snapcraft is necessary? >> (i.e. users are required to upgrade snapcraft from --edge ?) >> >> I guess the answer is yes, because "plugin: kernel" needs to know >> the kernel-build system internal. > > Well, in this case, i had to fix the 'kernel-with-firmware' option to > skip the 'firmware_install' step since > we took it by default - let's say that in the future the > 'modules_install' target is removed or change name, > then i'll have to patch snapcraft. > > Wrt updating from -edge, i told you to take it from there because snap > packages land there more often and more quickly > compared to the canonicaldeb archive, so from a developer perspective > it's easier&quicker to iterate over it, but sooner > or later (e.g. once snapcraft 2.36.1 reaches the snap -stable > channel), it will be copied to the deb archive too - > IOW, you would get using apt-get only too. > -- I will pick up this for v4.16-rc1. It sounds like this target is a bit fragile, but let's see. I hope a breakage will not happen... -- Best Regards Masahiro Yamada