Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754702AbdLGPem (ORCPT ); Thu, 7 Dec 2017 10:34:42 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:51306 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308AbdLGPek (ORCPT ); Thu, 7 Dec 2017 10:34:40 -0500 Date: Thu, 7 Dec 2017 16:34:38 +0100 From: Andrew Lunn To: Jerome Brunet Cc: Florian Fainelli , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 1/8] net: phy: meson-gxl: check phy_write return value Message-ID: <20171207153438.GF24750@lunn.ch> References: <20171207142715.32578-1-jbrunet@baylibre.com> <20171207142715.32578-2-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207142715.32578-2-jbrunet@baylibre.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 244 Lines: 8 On Thu, Dec 07, 2017 at 03:27:08PM +0100, Jerome Brunet wrote: > Always check phy_write return values. Better to be safe than sorry > > Signed-off-by: Jerome Brunet Reviewed-by: Andrew Lunn Andrew