Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753375AbdLGQeI (ORCPT ); Thu, 7 Dec 2017 11:34:08 -0500 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:24875 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752580AbdLGQeF (ORCPT ); Thu, 7 Dec 2017 11:34:05 -0500 X-IronPort-AV: E=Sophos;i="5.45,373,1508828400"; d="scan'208";a="7194173" Subject: Re: [PATCH v2] clocksource: tcb_clksrc: Fix clock speed message To: Daniel Lezcano , Romain Izard CC: Thomas Gleixner , , , Alexandre Belloni References: <20171201122233.21828-1-romain.izard.pro@gmail.com> <6f3d309e-2e71-3f60-5910-0d8b1f051836@linaro.org> From: Nicolas Ferre Organization: microchip Message-ID: <99fd8a35-9522-bb80-9aea-e4c266cdbc62@microchip.com> Date: Thu, 7 Dec 2017 17:34:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <6f3d309e-2e71-3f60-5910-0d8b1f051836@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1638 Lines: 52 On 07/12/2017 at 12:01, Daniel Lezcano wrote: > On 01/12/2017 13:22, Romain Izard wrote: >> The clock speed displayed at boot in an information message was 500 kHz >> too high compared to its real value. As the value is not used anywhere, >> there is no functional impact. >> >> Fix the rounding formula to display the correct value. >> >> Signed-off-by: Romain Izard >> --- >> v2: rebase over v4.15-rc1 >> >> There is no specified maintainer for this file, only supporters. > > That is not correct, it defaults to Thomas and me, the maintainers of > drivers/clocksource :) > >> Nicolas, could you pick this through the at91 tree as the TCB block >> is an AT91 peripheral ? > > Nicolas, do you agree with this change ? If yes, I will take it. Yes, fine with me: Acked-by: Nicolas Ferre Thanks Daniel for the "heads-up". Best regards, Nicolas >> drivers/clocksource/tcb_clksrc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c >> index 9de47d4d2d9e..43f4d5c4d6fa 100644 >> --- a/drivers/clocksource/tcb_clksrc.c >> +++ b/drivers/clocksource/tcb_clksrc.c >> @@ -384,7 +384,7 @@ static int __init tcb_clksrc_init(void) >> >> printk(bootinfo, clksrc.name, CONFIG_ATMEL_TCB_CLKSRC_BLOCK, >> divided_rate / 1000000, >> - ((divided_rate + 500000) % 1000000) / 1000); >> + ((divided_rate % 1000000) + 500) / 1000); >> if (tc->tcb_config && tc->tcb_config->counter_width == 32) { >> /* use apropriate function to read 32 bit counter */ >> > > -- Nicolas Ferre