Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932528AbdLGRYf (ORCPT ); Thu, 7 Dec 2017 12:24:35 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:39691 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756261AbdLGRYa (ORCPT ); Thu, 7 Dec 2017 12:24:30 -0500 X-Google-Smtp-Source: AGs4zMb7LZ3djIpSTsSYFpPIBsEBTgN/yAKlWyb1WzdlcCj8L0pE8rnwSjjjbSPAr1EcooH+g36+Ag== Date: Thu, 7 Dec 2017 09:24:26 -0800 From: Brian Norris To: Philippe CORNU Cc: Nickey Yang , "robh+dt@kernel.org" , "heiko@sntech.de" , "mark.rutland@arm.com" , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-rockchip@lists.infradead.org" , "laurent.pinchart@ideasonboard.com" , "seanpaul@chromium.org" , "mka@chromium.org" , "hoegsberg@gmail.com" , "architt@codeaurora.org" , Yannick FERTRE , "hl@rock-chips.com" , "zyw@rock-chips.com" , "xbl@rock-chips.com" Subject: Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata Message-ID: <20171207172424.GA41020@google.com> References: <1512551301-12946-1-git-send-email-nickey.yang@rock-chips.com> <1512551301-12946-2-git-send-email-nickey.yang@rock-chips.com> <20171206213858.GA14257@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 45 On Thu, Dec 07, 2017 at 11:41:17AM +0000, Philippe CORNU wrote: > platform_set_drvdata() is still missing in your version. Ugh...indeed. > On 12/06/2017 10:39 PM, Brian Norris wrote: > > On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote: > >> From: Brian Norris > >> > >> Bridge drivers/helpers shouldn't be clobbering the drvdata, since a > >> parent driver might need to own this. Instead, let's return our > >> 'dw_mipi_dsi' object and have callers pass that back to us for removal. > >> > >> Signed-off-by: Brian Norris > >> Signed-off-by: Nickey Yang > >> Link:https://patchwork.kernel.org/patch/10078493/ > >> > >> --- > >> Changes > >> > >> v4: > >> - Add From tag,update subject line > >> - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove" > >> in this piece together. > >> > >> v5: > >> - remove Review & Ack tag > >> - fix remove() directly referencing the static > >> dw_mipi_dsi_stm_plat_data struct. > > > > You've gotten this back into basically the shape I sent v1 in, so I > > guess this deserves an: > > > > Acked-by: Brian Norris ...and I even diffed the two directly and didn't notice that one missing at first :( So instead, make that: Nacked-by: Brian Norris Can you *please* just use my patch and reword the commit message/subject per the original comments on version 1? You're screwing it up every time you try to change it...