Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbdLGRiW (ORCPT ); Thu, 7 Dec 2017 12:38:22 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:51357 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090AbdLGPtp (ORCPT ); Thu, 7 Dec 2017 10:49:45 -0500 Date: Thu, 7 Dec 2017 16:49:43 +0100 From: Andrew Lunn To: Jerome Brunet Cc: Florian Fainelli , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 6/8] net: phy: meson-gxl: leave CONFIG_A6 untouched Message-ID: <20171207154943.GI24750@lunn.ch> References: <20171207142715.32578-1-jbrunet@baylibre.com> <20171207142715.32578-7-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207142715.32578-7-jbrunet@baylibre.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 508 Lines: 12 On Thu, Dec 07, 2017 at 03:27:13PM +0100, Jerome Brunet wrote: > The PHY performs just as well when left in its default configuration and > it makes senses because this poke gets reset just after init. The only thing which might speak against this, is some bootloader which sets something other than the default, and here we put it back to the value it should have. But if you say a reset will put it back to the default value anyway, this seems save. Reviewed-by: Andrew Lunn Andrew