Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753373AbdLGRu7 (ORCPT ); Thu, 7 Dec 2017 12:50:59 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58960 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbdLGRuy (ORCPT ); Thu, 7 Dec 2017 12:50:54 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DC4B76083C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback To: =?UTF-8?Q?Lothar_Wa=c3=9fmann?= Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, timur@codeaurora.org, open list , linux-acpi@vger.kernel.org, Rob Herring , dmaengine@vger.kernel.org, Frank Rowand , linux-arm-kernel@lists.infradead.org References: <1512493493-6464-1-git-send-email-okaya@codeaurora.org> <1512493493-6464-5-git-send-email-okaya@codeaurora.org> <20171207141029.575c0a03@karo-electronics.de> <20171207162036.6a71a4f5@karo-electronics.de> From: Sinan Kaya Message-ID: <661cbe4d-ea33-3e84-b5f2-ab6517cbb135@codeaurora.org> Date: Thu, 7 Dec 2017 12:50:50 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171207162036.6a71a4f5@karo-electronics.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 34 On 12/7/2017 10:20 AM, Lothar Waßmann wrote: > Hi, > > On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: >> On 12/7/2017 8:10 AM, Lothar Waßmann wrote: >>>> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, >>>> + struct device *dev) >>> Shouldn't this be 'const void *of_fwnode_get_match_data >> >> OF keeps the driver data as a (const void*) internally. ACPI keeps the >> driver data as kernel_ulong_t in struct acpi_device_id. >> >> I tried to find the middle ground here by converting output to void* >> but not keeping const. >> > It should be no problem to cast a (const void *) to an unsigned long > data type (without const qualifier). > It is the other way around. If I change this API to return a a (const void*), the device_get_match_data() function need to return a (const void *). While implementing the ACPI piece, I have to convert an unsigned long to (const void *) in ACPI code so that the APIs are compatible. > > Lothar Waßmann > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.