Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753001AbdLGSll (ORCPT ); Thu, 7 Dec 2017 13:41:41 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:42076 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbdLGSli (ORCPT ); Thu, 7 Dec 2017 13:41:38 -0500 Date: Thu, 07 Dec 2017 13:41:36 -0500 (EST) Message-Id: <20171207.134136.1871493292266283592.davem@davemloft.net> To: Tobias.Jordan@elektrobit.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] net: mvmdio: disable/unprepare clocks in EPROBE_DEFER case From: David Miller In-Reply-To: <20171206142323.6hbm54leg2maanbj@agrajag.zerfleddert.de> References: <20171206142323.6hbm54leg2maanbj@agrajag.zerfleddert.de> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Dec 2017 10:41:38 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 17 From: Tobias Jordan Date: Wed, 6 Dec 2017 15:23:23 +0100 > add appropriate calls to clk_disable_unprepare() by jumping to out_mdio > in case orion_mdio_probe() returns -EPROBE_DEFER. > > Found by Linux Driver Verification project (linuxtesting.org). > > Fixes: 3d604da1e954 net: mvmdio: get and enable optional clock > Signed-off-by: Tobias Jordan Applied, but please in the future format your Fixes: tag properly. You need to put the commit message header line inside of parenthesis and double quotes, like this: Fixes: 3d604da1e954 ("net: mvmdio: get and enable optional clock")