Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbdLGTOT (ORCPT ); Thu, 7 Dec 2017 14:14:19 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:42680 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbdLGTOQ (ORCPT ); Thu, 7 Dec 2017 14:14:16 -0500 Date: Thu, 07 Dec 2017 14:14:14 -0500 (EST) Message-Id: <20171207.141414.1589365570542864289.davem@davemloft.net> To: aleksey.makarov@cavium.com Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sunil.Goutham@cavium.com, rad@semihalf.com, rric@kernel.org, ddaney@caviumnetworks.com Subject: Re: [PATCH net-next v3 0/2] net: thunderx: add support for PTP clock From: David Miller In-Reply-To: <20171207.133932.904724095727636711.davem@davemloft.net> References: <20171206133100.26436-1-aleksey.makarov@cavium.com> <20171207.133932.904724095727636711.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Dec 2017 11:14:16 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB7JEM1Z007928 Content-Length: 1268 Lines: 27 From: David Miller Date: Thu, 07 Dec 2017 13:39:32 -0500 (EST) > From: Aleksey Makarov > Date: Wed, 6 Dec 2017 16:30:56 +0300 > >> This series adds support for IEEE 1588 Precision Time Protocol >> to Cavium ethernet driver. > > Series applied, thank you. Actually, this doesn't even compile, I'm reverting: drivers/net/ethernet/cavium/common/cavium_ptp.c:64:20: error: redefinition of ?cavium_ptp_get? struct cavium_ptp *cavium_ptp_get(void) ^~~~~~~~~~~~~~ In file included from drivers/net/ethernet/cavium/common/cavium_ptp.c:19:0: drivers/net/ethernet/cavium/common/cavium_ptp.h:59:34: note: previous definition of ?cavium_ptp_get? was here static inline struct cavium_ptp *cavium_ptp_get(void) ^~~~~~~~~~~~~~ drivers/net/ethernet/cavium/common/cavium_ptp.c:84:6: error: redefinition of ?cavium_ptp_put? void cavium_ptp_put(struct cavium_ptp *ptp) ^~~~~~~~~~~~~~ In file included from drivers/net/ethernet/cavium/common/cavium_ptp.c:19:0: drivers/net/ethernet/cavium/common/cavium_ptp.h:64:20: note: previous definition of ?cavium_ptp_put? was here static inline void cavium_ptp_put(struct cavium_ptp *ptp) {} ^~~~~~~~~~~~~~