Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbdLGTxd (ORCPT ); Thu, 7 Dec 2017 14:53:33 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:43270 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbdLGTxc (ORCPT ); Thu, 7 Dec 2017 14:53:32 -0500 Date: Thu, 07 Dec 2017 14:53:29 -0500 (EST) Message-Id: <20171207.145329.1140922105125090186.davem@davemloft.net> To: antoine.tenart@free-electrons.com Cc: gregory.clement@free-electrons.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/6] net: mvpp2: only free the TSO header buffers when it was allocated From: David Miller In-Reply-To: <20171207084903.27144-2-antoine.tenart@free-electrons.com> References: <20171207084903.27144-1-antoine.tenart@free-electrons.com> <20171207084903.27144-2-antoine.tenart@free-electrons.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Dec 2017 11:53:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 470 Lines: 13 From: Antoine Tenart Date: Thu, 7 Dec 2017 09:48:58 +0100 > This patch adds a check to only free the TSO header buffer when its > allocation previously succeeded. > > Signed-off-by: Antoine Tenart No, please keep this as a failure to bring up. Even if you emit a log message, it is completely unintuitive to have netdev features change on the user just because of a memory allocation failure.