Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbdLGUCr (ORCPT ); Thu, 7 Dec 2017 15:02:47 -0500 Received: from out0-224.mail.aliyun.com ([140.205.0.224]:45157 "EHLO out0-224.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbdLGUCp (ORCPT ); Thu, 7 Dec 2017 15:02:45 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01546;MF=yang.s@alibaba-inc.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---.9d0SkUb_1512676954; Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h To: Jon Maloy , "linux-kernel@vger.kernel.org" Cc: "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "netdev@vger.kernel.org" , Ying Xue , "David S. Miller" References: <1510959741-31109-1-git-send-email-yang.s@alibaba-inc.com> <1510959741-31109-8-git-send-email-yang.s@alibaba-inc.com> From: "Yang Shi" Message-ID: <294b155f-90e6-e505-7fc4-b9e0c492fed6@alibaba-inc.com> Date: Fri, 08 Dec 2017 04:02:33 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1642 Lines: 61 On 12/7/17 11:20 AM, Jon Maloy wrote: > > >> -----Original Message----- >> From: netdev-owner@vger.kernel.org [mailto:netdev- >> owner@vger.kernel.org] On Behalf Of Yang Shi >> Sent: Thursday, December 07, 2017 14:16 >> To: linux-kernel@vger.kernel.org >> Cc: linux-mm@kvack.org; linux-fsdevel@vger.kernel.org; linux- >> crypto@vger.kernel.org; netdev@vger.kernel.org; Jon Maloy >> ; Ying Xue ; David S. >> Miller >> Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h >> >> Hi folks, >> >> Any comment on this one? > > If it compiles it is ok with me. Don't know why it was put there in the first place. Yes, it does compile. Yang > > ///jon > >> >> Thanks, >> Yang >> >> >> On 11/17/17 3:02 PM, Yang Shi wrote: >>> Preempt counter APIs have been split out, currently, hardirq.h just >>> includes irq_enter/exit APIs which are not used by TIPC at all. >>> >>> So, remove the unused hardirq.h. >>> >>> Signed-off-by: Yang Shi >>> Cc: Jon Maloy >>> Cc: Ying Xue >>> Cc: "David S. Miller" >>> --- >>> net/tipc/core.h | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072 >>> 100644 >>> --- a/net/tipc/core.h >>> +++ b/net/tipc/core.h >>> @@ -49,7 +49,6 @@ >>> #include >>> #include >>> #include >>> -#include >>> #include >>> #include >>> #include >>>