Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbdLGU7i (ORCPT ); Thu, 7 Dec 2017 15:59:38 -0500 Received: from mail-pg0-f42.google.com ([74.125.83.42]:46502 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbdLGU7g (ORCPT ); Thu, 7 Dec 2017 15:59:36 -0500 X-Google-Smtp-Source: AGs4zMZdpcbRwmpMrpo16cpSWGklRTx4HSC80xN4vSIHWjQykVOvDm+dzsYq4O6BbL/CSRm2VIjWSw== Date: Thu, 07 Dec 2017 12:59:35 -0800 (PST) X-Google-Original-Date: Thu, 07 Dec 2017 12:59:33 PST (-0800) Subject: Re: [patches] Re: [GIT PULL] RISC-V Cleanups and ABI Fixes for 4.15-rc2 In-Reply-To: <20171203032002.GA4207@andrea> CC: Linus Torvalds , linux-kernel@vger.kernel.org, patches@groups.riscv.org, stern@rowland.harvard.edu, paulmck@linux.vnet.ibm.com From: Palmer Dabbelt To: parri.andrea@gmail.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 21 On Sat, 02 Dec 2017 19:20:02 PST (-0800), parri.andrea@gmail.com wrote: > On Fri, Dec 01, 2017 at 01:39:12PM -0800, Palmer Dabbelt wrote: >> RISC-V: Remove smb_mb__{before,after}_spinlock() > > I wonder whether you really meant to remove smp_mb__after_spinlock(): > on the one hand, this primitive doesn't seem "obsolete" (as suggested > by the commit message); on the other hand, the Draft Specification at > > https://marc.info/?l=linux-kernel&m=151218405830993&w=2 > > suggests that you need "to strengthen" the generic implementation for > this primitive (considered the current spinlock.h in riscv). What am > I missing? The comment was incorrect, which caused me to incorrectly remove the fence from our port. I just sent out a patch (well, actually, I did last night -- I just found this email sitting in a buffer...). https://lkml.org/lkml/2017/12/6/1136 Thanks for catching this!