Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752035AbdLGVdy (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Dec 2017 16:33:54 -0500
Received: from mail-oi0-f54.google.com ([209.85.218.54]:37756 "EHLO
        mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750996AbdLGVdw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2017 16:33:52 -0500
X-Google-Smtp-Source: AGs4zMYE92Ewt97fn3XjuVkPrTb5Zq/k68lwUy9Zo/tFbdkdGSql+BtsISrKSJTbaVVj/5ePTfb9VJv876kybmZ0Oq4=
MIME-Version: 1.0
In-Reply-To: <20171207190230.ttq5xthgsuuy4swn@pengutronix.de>
References: <1512657378-5221-1-git-send-email-svendev@arcx.com>
 <1512657378-5221-2-git-send-email-svendev@arcx.com> <CAMRc=MdhJRD+G18Xh5vfmaHHdJ+g9EnDTxUHVxhzDzVt-D0KMg@mail.gmail.com>
 <20171207190230.ttq5xthgsuuy4swn@pengutronix.de>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Thu, 7 Dec 2017 22:33:51 +0100
Message-ID: <CAMRc=MeEnDYjDTpE=XKuP3LricsnEnh0RHKMzxEPUcOS6E0tPQ@mail.gmail.com>
Subject: Re: [PATCH v5 1/2] at24: support eeproms that do not auto-rollover reads.
To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc: Sven Van Asbroeck <svendev@arcx.com>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Wolfram Sang <wsa@the-dreams.de>,
        nsekhar@ti.com, Sakari Ailus <sakari.ailus@linux.intel.com>,
        David Lechner <david@lechnology.com>,
        Javier Martinez Canillas <javier@dowhile0.org>,
        Divagar Mohandass <divagar.mohandass@intel.com>,
        devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-i2c <linux-i2c@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vB7LXwQQ001689
Content-Length: 563
Lines: 17

2017-12-07 20:02 GMT+01:00 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> Hello,
>
> On Thu, Dec 07, 2017 at 05:26:50PM +0100, Bartosz Golaszewski wrote:
>> > +       if (at24->chip.flags & AT24_FLAG_NO_RDROL) {
>> > +               bits = (at24->chip.flags & AT24_FLAG_ADDR16) ? 16 : 8;
>>
>> There's no need for braces around the ternary operator's condition.
>
> Even if not required, I'd keep them for clearity.
>

I don't want to start bikeshedding, so I'll take it as it is, but I
prefer to avoid braces wherever it's not necessary.

Thanks,
Bartosz