Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751942AbdLGVrt (ORCPT ); Thu, 7 Dec 2017 16:47:49 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:42423 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdLGVrr (ORCPT ); Thu, 7 Dec 2017 16:47:47 -0500 X-Google-Smtp-Source: AGs4zMaP8PHjAZfS9G7/5PH0RQkcAMa7etCN9tPZjn5DLmsXaBhVJQekA0Z4sxKu7A4Ub/PzLmqIBkzvU0juCfUlpr0= MIME-Version: 1.0 In-Reply-To: <1512682276-6082-3-git-send-email-dshah@xilinx.com> References: <20171207104757.GA27343@kroah.com> <1512682276-6082-1-git-send-email-dshah@xilinx.com> <1512682276-6082-3-git-send-email-dshah@xilinx.com> From: Philippe Ombredanne Date: Thu, 7 Dec 2017 22:47:05 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver To: Dhaval Shah Cc: Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , michal.simek@xilinx.com, hyunk@xilinx.com, Dhaval Shah Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 28 Dear Dhaval, On Thu, Dec 7, 2017 at 10:31 PM, Dhaval Shah wrote: > Xilinx ZYNQMP logicoreIP Init driver is based on the new > LogiCoreIP design created. This driver provides the processing system > and programmable logic isolation. Set the frequency based on the clock > information get from the logicoreIP register set. > > It is put in drivers/misc as there is no subsystem for this logicoreIP. > > Signed-off-by: Dhaval Shah > --- > Changes since v2: > * Removed the "default n" from the Kconfig > * More help text added to explain more about the logicoreIP driver > * SPDX id is relocated at top of the file with // style comment > * Removed the export API and header file and make it a single driver > which provides logocoreIP init. > * Provide the information in commit message as well for the why driver > in drivers/misc. Thank you for the SPDX comments updates. Acked-by: Philippe Ombredanne -- Cordially Philippe Ombredanne